[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 247149] KRDC shows wrong colors when connecting to Mac OS X
From:       Wouter Van Meir <wouter.vanmeir () pandora ! be>
Date:       2010-10-15 15:38:55
Message-ID: 20101015153855.1772ABE5F () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=247149





--- Comment #7 from Wouter Van Meir <wouter vanmeir pandora be>  2010-10-15 17:38:50 ---
The problem exists in kde 4.5 krdc when connecting to qemu vnc and Xvnc (and
probably OS X vnc). Krdc sends the wrong color info to the server. The problem
did not occur with x11vnc and krfb as vnc server, probably because of a bug in
these vnc servers (or libvncserver which they both use).

This bug was accidentally made by me (sorry) and was in an old patch to support
intel amt kvm (vnc server in chipset).
A later patch by me fixed this again. This later patch also puts high quality
to 32bit colors (like it was), medium to 16 bit and low to 8 bit. This saves
lots of bandwidth but makes low quality ugly. The patch is has been in the
trunk for some time.

Urs, could you merge this later patch in the kde 4.5 branch to fix this
problem?
This merge fixes it:
svn merge -r r1152685:r1157496
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/krdc
If you don't want this in kde 4.5 then I can make a new small patch to only fix
this specific problem.

The bug is more specifically that the wrong red shift, blue shift and green
shift values are send to the server (initialized by rfbGetClient()), the
correct values will be set (callback call to newclient()) after the "client set
pixel format" packet was send. (in newer libvncclient newclient() is called
sooner so this problem doesn't exist there). In the the trunk in revision
r1157496 the colors are correctly initialized before they're used.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]