[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 235821] using kwin shadows with oxygen creates artifact
From:       Hugo Pereira Da Costa <hugo.pereira () free ! fr>
Date:       2010-04-30 22:23:21
Message-ID: 20100430222321.0A91E3E8EB () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=235821





--- Comment #11 from Hugo Pereira Da Costa <hugo pereira free fr>  2010-05-01 00:23:17 ---
@thomas: 

I don't quite understand
"so if you've a deco with _real_ alpha channel
(not just fancy round corners), things will still look broken"
With my patch, if you completely disable any painting in
kcommondecoration::paintevent (with a return statement at the first line), you
have a shadow painted and buttons on top of it. Looks like total alpha channel
to me, and not broken. Is it ? Or what do I miss ? 

As for the mask you mention: I will not implement.

Shadow painting in kwin is slow, that's a fact and maybe made worse for oxygen
due to this alpha channel thing. I understood that this was the reason why the
KCommonDecoration API was modified in the first place to have decoration paint
their own shadows, which oxygen did. Then I re-added the possibility to use
kwin shadows on user request, which triggered a bug in kwin. 

I will not modify oxygen to fix this bug and re-add a mask for this already
corner case, cause IMO this is going backward. 

My view is: either we live with this performance drop for oxygen + fixed kwin
shadow (which is _not_ the original design), or we drop the possibility to have
kwin shadows + oxygen (and leave the bug open).

Now on the patch itself and the performance drop: if people want to have it
ported to the shadow pluggin only, I can give it a try (I failed last time I
tried, but understands the code better now). However, shadows will still be
made slower for decorations that use alpha channel, right ? 

I can also revert my change and leave the original bug open. But modifying
oxygen with ugly masks for this is not an option as far as I'm concerned ... 

Now, Svn is open. If someone wants to make (and maintain) that change to
oxygen, I wont object.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]