[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 235821] using kwin shadows with oxygen creates artifact
From:       Hugo Pereira Da Costa <hugo.pereira () free ! fr>
Date:       2010-04-30 18:40:40
Message-ID: 20100430184040.0ADC93EC5A () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=235821


Hugo Pereira Da Costa <hugo.pereira@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hugo.pereira@free.fr




--- Comment #5 from Hugo Pereira Da Costa <hugo pereira free fr>  2010-04-30 20:40:38 ---
To comment #3:

First: sorry there was a collision between your comment and my commit.

For the patch: only to decoration that sets the AbilityUsesAlphaChannel to true
are affected. And they should (cause the decoration is then allowed to put
transparency anywhere, and the shadow should be drawn behind).

Other decorations are unaffected.

"I also don't like the logic in topLevelDecorationHasAlpha() that if the client
window covers the decoration, then the decoration doesn't have an alpha
channel". This is used elsewhere in scene.cpp. That's apparently the only way
from scene.cpp to know whether the window has a decoration or not. I agree it
is suboptimal ...

"If we add a hint in the future that lets the client combine this with having
the client window cover the whole frame, then this logic will definitely not
work."

I actually don't think so, because the other check (isOpaque) check for the
client opacity setting, and its color depth. So that even if decorationAsAlpha
is false, the isOpaque will be true, and the PAINT_WINDOW_TRANSLUCENT will be
set.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]