[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 163538] Crash report on exiting KDE
From:       Hugo Pereira Da Costa <hugo.pereira () free ! fr>
Date:       2009-10-21 4:53:00
Message-ID: 20091021045300.E6B8C23F5A () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=163538


Hugo Pereira Da Costa <hugo.pereira@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hugo.pereira@free.fr




--- Comment #61 from Hugo Pereira Da Costa <hugo pereira free fr>  2009-10-21 06:52:52 ---
Hey,
The way I see it, I think most of these crashes are due to the fact that oxygen
helper use 
TileSet* and QPixmap* (pointers to) all over the place.

Using QPixmap* is not necessary: QPixmap is an implicitely shared class in Qt,
so that calling QPixmap copy constructor cost as much as passing a pointer
around. On the other hand, not using pointers to QPixmap would let Qt take care
of all the deletion, and should fix everything.

As for TileSet, since it basicaly contains only 9 QPixmap, same thing: not much
gain as passing pointers around rather than value (copy constructor): copying a
TileSet is basically copying 9 pointers.

To summarize, if people agree, I would try avoid totally the use of pointers to
TileSet, and the use of QPixmap* inside TileSet. That would prevent any memory
leak and destructor crash, unless there are issues inside Qt.

Any comment ?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]