[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 188378] plasma-desktop crashed while toggling window grouping
From:       "Aaron J.Seigo" <aseigo () kde ! org>
Date:       2009-06-21 19:29:34
Message-ID: 20090621192934.DDA6D1295E () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=188378


Aaron J. Seigo <aseigo@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #62 from Aaron J. Seigo <aseigo kde org>  2009-06-21 21:29:32 ---
SVN commit 984938 by aseigo:

don't delete the grouping strategy immediatley when changing it. this is due to
the following possible chain of events:

* window comes or goes
* the grouping strategy is asked to update the groups based on this event, and
tells the group manager about a change in events
* the group manager notifies the outside world about it
* the tasks widget's size changes becuase of this and that affects the optimal
number of entries to show, which it relays to the group manager
* the group manager realizes it now has enough room for all the tasks, and
switches the grouping strategy ... BY DELETING THE GROUPING STRATEGY!
* execution then eventually returns to wherever we were at step 2 ... BOOM
(with all sorts of oddness in the backtraces :)

this also explains why it was intermitent (change of grouping collection which
caused a size change in the tasks widget which altered the optimal number of
buttons) and only for some people ("only group when full" and with a variable
size tasks widget, e.g. on an expanding panel)

this is a pretty big set of changes, and i've gone over them carefully and
tested them as thoroughly as i can, but additional feedback from people using
SVN would be great as this is a big set of changes this close to release

CCMAIL:plasma-devel@kde.org
BUGS:193042,188378


 M  +37 -11    abstractgroupingstrategy.cpp  
 M  +7 -0      abstractgroupingstrategy.h  
 M  +23 -20    groupmanager.cpp  
 M  +6 -4      strategies/kustodiangroupingstrategy.cpp  
 M  +40 -31    strategies/manualgroupingstrategy.cpp  
 M  +14 -9     strategies/programgroupingstrategy.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=984938

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]