[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 191182] VALGRIND_LEAK_CHECK quadratic when big nr of chunks or
From:       Julian Seward <jseward () acm ! org>
Date:       2009-04-30 23:40:24
Message-ID: 20090430234024.120A116571 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=191182





--- Comment #3 from Julian Seward <jseward acm org>  2009-05-01 01:40:06 ---
> That is definitely some brain-dead code in print_results()!

Yes; I suspect I am the culprit :)

> I wonder if it can be fixed without all the hash table complexity...

I wondered that too.  Basically we're commoning up stack traces, right?
So we could just whack them into an OSet or WordFM, and supply a 
comparison function; but that's no big deal.  eg, a WordFM where
the keys are ExeContext*s and the values are a struct containing
the numbers of blocks and bytes associated with the ExeContext*.
Ah, but then to do the final printout, we need to visit these
(key, value) pairs in an order defined by the "total bytes lost"
field in the value structs.  So, not so simple.

Certainly though we should be able to do this using some combination
of the existing generic data structures (OSet, WordFM, XArray, SparseWA,
Hashtable) without modifying them.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]