[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 66492] keuphoria occasionally only using quarter of screen
From:       Ivo Anjo <knuckles () gmail ! com>
Date:       2009-04-01 10:03:15
Message-ID: 20090401100315.A205A15A9F () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=66492


Ivo Anjo <knuckles@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32515|0                           |1
        is obsolete|                            |




--- Comment #36 from Ivo Anjo <knuckles gmail com>  2009-04-01 12:03:07 ---
Created an attachment (id=32516)
 --> (http://bugs.kde.org/attachment.cgi?id=32516)
Fix, try 4

(In reply to comment #35)

Fixed most of the suggestions, thanks (the patch seems to be getting smaller, a
few more iterations and don't I anything will be left).

> given that the private object contains exactly one pointer, it might be
> preferable to replace the unused d pointer with that one, adding a big fat note
> that if more members are added, they need to be moved to a private object.

As for this one, I think that would just complicate things, for a savings of a
couple of extra bytes, so I think this way is cleaner. (But if you think that
it really should be done that way, I could do that too).

Thanks

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]