[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 176329] Juk stop playing if I choose random mode
From:       Georg Grabler <ggrabler () gmail ! com>
Date:       2008-12-31 22:15:23
Message-ID: 20081231221523.43DDB13C71 () immanuel ! kde ! org
[Download RAW message or body]

http://bugs.kde.org/show_bug.cgi?id=176329





--- Comment #2 from Georg Grabler <ggrabler gmail com>  2008-12-31 23:15:22 ---
Created an attachment (id=29792)
 --> (http://bugs.kde.org/attachment.cgi?id=29792)
patch for playermanager removing the m_file check at slotNeedNextUrl

Hi,

The cause of this is the code in playermanager.cpp line 429-432
if(m_file.isNull())
{
  return;
}

Maybe this is in there for a reason, but I havn't found it yet. m_file is in
this case always null, since slotFinished (which is emitted when a track
finishes) sets m_file = FileHandle::null();

I think setting m_file to FileHandle::null has a good reason, but the check in
slotNeedNextUrl does not really make sense.

I just kicked out the part of slotNeedNextUrl, and till now it works properly.
patch attached.

Kind regards,
Georg


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]