[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 161276] Items whose text fits in two lines in the call graph
From:       Josef Weidendorfer <josef.weidendorfer () gmx ! de>
Date:       2008-05-30 17:51:51
Message-ID: 20080530175151.18680.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=161276         




------- Additional Comments From josef.weidendorfer gmx de  2008-05-30 19:51 -------
Created an attachment (id=25016)
 --> (http://bugs.kde.org/attachment.cgi?id=25016&action=view)
Small Callgraph screenshot for me with patch

Hi,

with your patch, overlapping of text lines is possible, as can be
seen in the attached screenshot on the left.
You are right that on the right, 3 lines seem to fit into the rectangle.
However, the second symbol line and the percentage text are quite near
to each other; actually, they overlap when taking the bounding
boxes (as given by QFontMetrics) into account.

Is this different for you?
KCachegrind just uses the normal font size here. If you change the font
size, more text lines should fit into a rectangle.

I really would like to revert this thunk in commit 801192. Perhaps this
was done accidentally, as the commit text talks about "Q3MemArray begone!"
(By the way, thanks for the rest of this patch!).

Josef
[prev in list] [next in list] [prev in thread] [next in thread]