[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 149666] [PATCH] iPod Export kipi plugin cannot be disabled at
From:       "MatÄj" Laitl <strohel () gmail ! com>
Date:       2007-10-03 21:37:34
Message-ID: 20071003213734.21135.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=149666         
strohel gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21562|0                           |1
        is obsolete|                            |



------- Additional Comments From strohel gmail com  2007-10-03 23:37 -------
Created an attachment (id=21745)
 --> (http://bugs.kde.org/attachment.cgi?id=21745&action=view)
kipi-plugins-0.1.4-builsystem-tweaks-v1.patch

After a few days of autoconf/automake/m4/shell torture, I'm proud to announce
v1 of my patch. ;)

Depending on where you patch, do it with -p1 or -p2.

Features:
* As ./configure --help says, it is now possible to enable or disable every
kipi plugin, defaulting to enable, if depencencies are meet.
* It should also simplify adding new patches, it would require adding 2 lines
to configure.in.in and 5 lines to Makefile.am.
* Dependencies are handled automatically, each plugin can have multiple
dependencies and one dependency can be shared by multiple plugins. You list
them only once for each plugin.
* configure.in.bot is tweaked so it shows most accurate and helpful
information. (including what plugins will and will not be built, what libs will
and will not be used, what libs would be needed to enable not-presently-enabled
plugins)

To resolve:
* Current behaviour is to fail when --enable-feature was given to ./configure
and dependencies for feature are not satisfied. Is it feasible?
* what about sync and imagesgallery plugins? They weren't listed in Makefile.am


P.S.: It's quite late now, so there may be naughty mistakes in my patch.
Nonetheless it works for me, but YMMV, so give it a good testing please. I'm
open to all comments and improvements.
P.P.S.: Some day, I may fall in love with cmake. If it happens, there is a
possibility I would do something similar for KDE4 kipi-plugins.

Matěj Laitl, your foolish buildsystem tweaker.
[prev in list] [next in list] [prev in thread] [next in thread]