[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 146504] "configure podcasts" menu entry has no effect if no
From:       Jeff Mitchell <kde-dev () emailgoeshere ! com>
Date:       2007-09-01 18:20:10
Message-ID: 20070901182010.30740.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=146504         
kde-dev emailgoeshere com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From kde-dev emailgoeshere com  2007-09-01 20:20 -------
SVN commit 707393 by mitchell:

Don't enable "Configure Podcasts" at the top level Podcasts folder if there's nothing \
underneath.  It'll still be a do-nothing op if only subfolders are  underneath, but \
fixing it further is too much needless hacking on stable branch.

BUG: 146504


 M  +2 -0      ChangeLog  
 M  +2 -0      src/playlistbrowseritem.cpp  


--- branches/stable/extragear/multimedia/amarok/ChangeLog #707392:707393
 @ -5,6 +5,8  @
 
 VERSION 1.4.8
   BUGFIXES:
+    * Don't enable "Configure Podcasts" at the top-level Podcasts folder if
+      there is nothing beneath it. (BR 146504)
     * Generic Media Device could copy some non-ASCII filenames to turn to
       gibberish.  Thanks to David Smith <davidsmith acm org> for the fix.
     * Fixed possible GUI freeze when Amarok was showing the dialog for
--- branches/stable/extragear/multimedia/amarok/src/playlistbrowseritem.cpp \
#707392:707393  @ -438,6 +438,8  @
         menu.insertItem( SmallIconSet( Amarok::icon( "refresh" ) ), i18n("Refresh \
All Podcasts"), REFRESH );  menu.insertSeparator();
         menu.insertItem( SmallIconSet( Amarok::icon( "configure" ) ), i18n( \
"&Configure Podcasts..." ), CONFIG ); +        if( parentCat->childCount() == 0 )
+            menu.setItemEnabled( CONFIG, false );
         if( parentCat == this )
             menu.insertItem( SmallIconSet( Amarok::icon( "configure" ) ), i18n("Scan \
Interval..."), INTERVAL );  }


[prev in list] [next in list] [prev in thread] [next in thread]