[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 147404] Radio Streams drag-and-drop severely broken
From:       Seb Ruiz <ruiz () kde ! org>
Date:       2007-07-01 5:53:46
Message-ID: 20070701055346.25340.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=147404         
ruiz kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From ruiz kde org  2007-07-01 07:53 -------
SVN commit 681998 by seb:

Accept playlistbrowser drops on items, and assign the new item to the category of the \
                item dropped on.
BUG: 147404


 M  +9 -5      playlistbrowser.cpp  


--- branches/stable/extragear/multimedia/amarok/src/playlistbrowser.cpp \
#681997:681998  @ -2782,10 +2782,17  @
 
 void PlaylistBrowserView::moveSelectedItems( QListViewItem *newParent )
 {
-    if( !newParent || isDynamic( newParent ) || isPodcastChannel( newParent ) ||
-         isSmartPlaylist( newParent ) || isPodcastEpisode( newParent ) )
+    if( !newParent )
         return;
 
+    QListViewItem *after=0;
+    if( isDynamic( newParent ) || isPodcastChannel( newParent ) ||
+        isSmartPlaylist( newParent ) || isPodcastEpisode( newParent ) || isStream( \
newParent ) ) +    {
+        after = newParent;
+        newParent = newParent->parent();
+    }
+
     #define newParent static_cast<PlaylistBrowserEntry*>(newParent)
     if( !newParent->isKept() )
         return;
 @ -2801,7 +2808,6  @
         selected.append( *it );
     }
 
-    QListViewItem *after=0;
     for( QListViewItem *item = selected.first(); item; item = selected.next() )
     {
         QListViewItem *itemParent = item->parent();
 @ -2889,8 +2895,6  @
 
 void PlaylistBrowserView::startDrag()
 {
-    DEBUG_BLOCK
-
     KURL::List urls;
     KURL::List itemList; // this is for CollectionDB::createDragPixmap()
     KURL::List podList;  // used to add podcast episodes of the same channel in \
reverse order (usability)


[prev in list] [next in list] [prev in thread] [next in thread]