[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 137762] kmplayer_part does not start playback before website is
From:       Koos Vriezen <koos.vriezen () gmail ! com>
Date:       2006-12-22 13:53:20
Message-ID: 20061222135320.27209.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=137762         
koos.vriezen gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From koos.vriezen gmail com  2006-12-22 14:53 -------
SVN commit 615743 by vriezen:

Only emit started with autoplay 

BUG: 137762

I hope you agree that when 'autostart=0' is set, the video should not 
autostart.


 M  +9 -5      kmplayer_part.cpp  
 M  +1 -0      kmplayersource.h  


--- trunk/extragear/multimedia/kmplayer/src/kmplayer_part.cpp #615742:615743
 @ -471,9 +471,11  @
         setSource (hrefsource);
     } else {
         hrefsource->clear ();
-        PartBase::openURL (m_havehref ? m_sources ["urlsource"]->url () : url);
-        emit started (0L);
-        m_started_emited = true;
+        PartBase::openURL (m_havehref ? urlsource->url () : url);
+        if (urlsource->autoPlay ()) {
+            emit started (0L);
+            m_started_emited = true;
+        }
         m_havehref = false;
     }
     return true;
 @ -565,8 +567,10  @
     if (m_settings->sizeratio && !m_noresize && m_source->width() > 0 && m_source->height() > 0)
         m_liveconnectextension->setSize (m_source->width(), m_source->height());
     m_browserextension->setLoadingProgress (100);
-    emit completed ();
-    m_started_emited = false;
+    if (m_started_emited) {
+        emit completed ();
+        m_started_emited = false;
+    }
     m_liveconnectextension->started ();
     m_browserextension->infoMessage (i18n("KMPlayer: Playing"));
 }
--- trunk/extragear/multimedia/kmplayer/src/kmplayersource.h #615742:615743
 @ -97,6 +97,7  @
     // backend process state changed
     virtual void stateChange (Process *, Process::State os, Process::State ns);
     KDE_NO_EXPORT void setAutoPlay (bool b) { m_auto_play = b; }
+    KDE_NO_EXPORT bool autoPlay () const { return m_auto_play; }
     void setTitle (const QString & title);
     void setLoading (int percentage);
     bool setCurrent (NodePtr mrl);
[prev in list] [next in list] [prev in thread] [next in thread]