[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 128394] Convertion of RAW files fails with dcraw 8.21
From:       Gilles Caulier <caulier.gilles () free ! fr>
Date:       2006-09-14 9:11:33
Message-ID: 20060914091133.4747.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=128394         




------- Additional Comments From caulier.gilles free fr  2006-09-14 11:11 -------
SVN commit 584176 by cgilles:

kipi-plugins from trunk : Raw Converter : dcraw version detection at startup. Code \
come from digiKam project

CCMAIL: kde-imaging kde org

CCBUGS: 107905, 128394

 M  +1 -1      Makefile.am  
 A             dcrawbinary.cpp   [License: GPL]
 A             dcrawbinary.h   [License: GPL]
 M  +31 -18    plugin_rawconverter.cpp  


--- trunk/extragear/libs/kipi-plugins/rawconverter/Makefile.am #584175:584176
 @ -12,7 +12,7  @
 # Srcs for the plugin
 kipiplugin_rawconverter_la_SOURCES = plugin_rawconverter.cpp dcrawiface.cpp \
                savesettingswidget.cpp \
 	                             batchdialog.cpp actionthread.cpp \
                dcrawsettingswidget.cpp \
-	                             singledialog.cpp previewwidget.cpp iccjpeg.c 
+	                             singledialog.cpp previewwidget.cpp iccjpeg.c \
dcrawbinary.cpp   
 # Libs needed by the plugin
 kipiplugin_rawconverter_la_LIBADD = -ljpeg -lpng $(LIB_TIFF) $(LIBKIPI_LIBS) \
                $(LIB_KIO) $(LIB_KDEUI) $(LIB_KDECORE) $(LIB_QT)
--- trunk/extragear/libs/kipi-plugins/rawconverter/plugin_rawconverter.cpp \
#584175:584176  @ -53,6 +53,7  @
 // Local includes.
 
 #include "rawfiles.h"
+#include "dcrawbinary.h"
 #include "singledialog.h"
 #include "batchdialog.h"
 #include "plugin_rawconverter.h"
 @ -123,30 +124,42  @
 
 bool Plugin_RawConverter::checkBinaries()
 {
-    QProcess process;
+    KIPIRawConverterPlugin::DcrawBinary dcrawBinary;
 
-    process.clearArguments();
-    process.addArgument("kipidcrawclient");
-
-    if (!process.start()) 
+    if (!dcrawBinary.isAvailable()) 
     {
-        KMessageBox::error(kapp->activeWindow(), i18n("Failed to start raw converter \
                client.\n"
-                                                      "Please check your \
installation.")); +        KMessageBox::information(
+                     kapp->activeWindow(),
+                     i18n("<qt><p>Unable to find the dcraw executable:<br> "
+                          "This program is required by this plugin to support raw \
file decoding. " +                          "Please install dcraw as a package from \
your distributor " +                          "or <a href=\"%1\">download the \
source</a>.</p>" +                          "<p>Note: at least, dcraw version %2 is \
required by this plugin.</p></qt>") +                          \
.arg("http://www.cybercom.net/~dcoffin/dcraw") +                          \
.arg(dcrawBinary.minimalVersion()), +                     QString::null,
+                     QString::null,
+                     KMessageBox::Notify | KMessageBox::AllowLink);
         return false;
     }
 
-    process.clearArguments();
-    process.addArgument("dcraw");
-
-    if (!process.start()) 
+    if (!dcrawBinary.versionIsRight()) 
     {
-        KMessageBox::error(kapp->activeWindow(),
-                           i18n("<qt><p>Unable to find the dcraw executable:<br> "
-                                "This program is required to process Raw file \
                formats conversion. "
-                                "Please install dcraw as a package from your \
                distributor "
-                                "or <a href=\"%2\">download the \
                source</a>.</p></qt>")
-                                .arg("http://www.cybercom.net/~dcoffin/dcraw/"));    \
                
-
+        KMessageBox::information(
+                     kapp->activeWindow(),
+                     i18n("<qt><p>dcraw executable isn't up to date:<br> "
+                          "The version %1 of dcraw have been found on your computer. \
" +                          "This version is too old to run properlly with this \
plugin. " +                          "Please update dcraw as a package from your \
distributor " +                          "or <a href=\"%2\">download the \
source</a>.</p>" +                          "<p>Note: at least, dcraw version %3 is \
required by this " +                          "plugin</p></qt>")
+                          .arg(dcrawBinary.version())
+                          .arg("http://www.cybercom.net/~dcoffin/dcraw")
+                          .arg(dcrawBinary.minimalVersion()),
+                     QString::null,
+                     QString::null,
+                     KMessageBox::Notify | KMessageBox::AllowLink);
         return false;
     }


[prev in list] [next in list] [prev in thread] [next in thread]