[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 95489] CSS attribute "height" (in body or table) isn't rendered
From:       Allan Sandfeld <kde () carewolf ! com>
Date:       2006-09-02 12:31:38
Message-ID: 20060902123138.30566.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=95489         
kde carewolf com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From kde carewolf com  2006-09-02 14:31 -------
SVN commit 580037 by carewolf:

Height of body should be based on canvas in quirks mode.
BUG:95489

Also affects quirksmode.org/css/height/minheightbody.html


 M  +8 -1      render_box.cpp  


--- branches/KDE/3.5/kdelibs/khtml/rendering/render_box.cpp #580036:580037
 @ -736,7 +736,7  @
         }
 
         if(!isInline() || isReplaced()) {
-            _xPos += xPos(), 
+            _xPos += xPos(),
             _yPos += yPos();
         }
 
 @ -1105,6 +1105,7  @
     if (cb->isTableCell() && style()->htmlHacks()) {
         result = static_cast<RenderTableCell*>(cb)->cellPercentageHeight();
     }
+
     // Otherwise we only use our percentage height if our containing block had a specified
     // height.
     else if (cb->style()->height().isFixed())
 @ -1132,6 +1133,12  @
                               p->borderTop() + p->borderBottom() +
                               p->paddingTop() + p->paddingBottom());
     }
+    else if (cb->isRoot() && style()->htmlHacks() && cb->style()->height().isVariable()) {
+        int visHeight = canvas()->viewportHeight();
+        result = visHeight - (marginTop() + marginBottom() +
+                              borderTop() + borderBottom() +
+                              paddingTop() + paddingBottom());
+    }
     else if (cb->isAnonymousBlock() || treatAsReplaced && style()->htmlHacks()) {
         // IE quirk.
         result = cb->calcPercentageHeight(cb->style()->height(), treatAsReplaced);
[prev in list] [next in list] [prev in thread] [next in thread]