[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 124648] bidirectional text selection failure in konqueror
From:       Charles Samuels <charles () kde ! org>
Date:       2006-04-02 23:14:55
Message-ID: 20060402231455.17932.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=124648         
charles kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From charles kde org  2006-04-03 01:14 -------
SVN commit 525823 by charles:

BUG: 124648

Lines that contain RTL text cannot be selected at the LTR text following the RTL text \
that follows the LTR text.



 M  +2 -2      render_text.cpp  


--- branches/KDE/3.5/kdelibs/khtml/rendering/render_text.cpp #525822:525823
 @ -307,12 +307,12  @
     }
     if ( _x > _tx + m_x + m_width ) {
 	// to the right
-	return m_reversed ? SelectionPointBeforeInLine : SelectionPointAfterInLine;
+	return  SelectionPointAfterInLine;
     }
 
     // The Y matches, check if we're on the left
     if ( _x < _tx + m_x ) {
-        return m_reversed ? SelectionPointAfterInLine : SelectionPointBeforeInLine;
+        return SelectionPointBeforeInLine;
     }
 
     // consider spacing for justified text


[prev in list] [next in list] [prev in thread] [next in thread]