From kde-bugs-dist Tue Jan 31 22:07:52 2006 From: Pau Capdevila Date: Tue, 31 Jan 2006 22:07:52 +0000 To: kde-bugs-dist Subject: [Bug 118793] Problematic characters break feed parsing Message-Id: <20060131220752.4689.qmail () ktown ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-bugs-dist&m=113874527707635 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. http://bugs.kde.org/show_bug.cgi?id=118793 ------- Additional Comments From pau.capdevila gmail com 2006-01-31 23:07 ------- I really admire you. I hope one day I'll be half a programmer as you. Thank you very much indeed! Pau On 31 Jan 2006 17:05:54 -0000, Frank Osterfeld wrote: [bugs.kde.org quoted mail] I really admire you.

I hope one day I'll be half a programmer as you.

Thank you very much indeed!

Pau

On 31 Jan 2006 17:05:54 -0000, Frank Osterfeld <frank osterfeld kdemail net> wrote:
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.

http://bugs.kde.org/show_bug.cgi?id=118793
frank.osterfeld kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From frank.osterfeld kdemail net  2006-01-31 18:05 -------
SVN commit 504290 by osterfeld:

RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and
just assume RSS 2.0. The older formats are compatible to 2.0, so this should work.
(at least better than refusing to parse the feeds)
BUG: 118793



M  +9 -0      ChangeLog
M  +2 -1      src/librss/document.cpp


--- branches/KDE/3.5/kdepim/akregator/ChangeLog #504289:504290
@ -2,6 +2,15  
===================
(c) 2004-2006 the Akregator authors.

+Changes after 1.2.1:
+-----------------------------
+
+Bug fixes:
+
+ 2006/01/31 RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and
+            just assume RSS 2.0. The older formats are compatible to 2.0, so this should work.
+            (at least better than refusing to parse the feeds) (#118793) -fo
+
Changes after 1.2:
-----------------------------

--- branches/KDE/3.5/kdepim/akregator/src/librss/document.cpp #504289:504290
@ -110,7 +110,8  
             d->version = v0_93;
         else if (attr == QString::fromLatin1("0.94"))
             d->version = v0_94;
-        else if (attr.startsWith("2.0") || attr == QString::fromLatin1("2")) // http://www.breuls.org/rss puts 2.00 in version (BR #0000016)
+        else // otherwise, we just assume a RSS2 compatible feed. As rss2 is generally
+             // backward-compatible, this should work
             d->version = v2_0;
     }