[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 118793] Problematic characters break feed parsing
From:       Frank Osterfeld <frank.osterfeld () kdemail ! net>
Date:       2006-01-31 17:05:54
Message-ID: 20060131170554.5944.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=118793         
frank.osterfeld kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From frank.osterfeld kdemail net  2006-01-31 18:05 \
------- SVN commit 504290 by osterfeld:

RSS parser: ignore unknown or invalid version attribute value in the <rss> tag and
just assume RSS 2.0. The older formats are compatible to 2.0, so this should work.
(at least better than refusing to parse the feeds)
BUG: 118793



 M  +9 -0      ChangeLog  
 M  +2 -1      src/librss/document.cpp  


--- branches/KDE/3.5/kdepim/akregator/ChangeLog #504289:504290
 @ -2,6 +2,15  @
 ===================
 (c) 2004-2006 the Akregator authors.
 
+Changes after 1.2.1:
+-----------------------------
+
+Bug fixes:
+
+ 2006/01/31 RSS parser: ignore unknown or invalid version attribute value in the \
<rss> tag and +            just assume RSS 2.0. The older formats are compatible to \
2.0, so this should work. +            (at least better than refusing to parse the \
feeds) (#118793) -fo +
 Changes after 1.2:
 -----------------------------
 
--- branches/KDE/3.5/kdepim/akregator/src/librss/document.cpp #504289:504290
 @ -110,7 +110,8  @
             d->version = v0_93;
         else if (attr == QString::fromLatin1("0.94"))
             d->version = v0_94;
-        else if (attr.startsWith("2.0") || attr == QString::fromLatin1("2")) // \
http://www.breuls.org/rss puts 2.00 in version (BR #0000016) +        else // \
otherwise, we just assume a RSS2 compatible feed. As rss2 is generally +             \
// backward-compatible, this should work  d->version = v2_0;
     }


[prev in list] [next in list] [prev in thread] [next in thread]