[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 117437] line breaks not rendered properly in edit view
From:       Michael Brade <brade () kde ! org>
Date:       2006-01-06 22:54:20
Message-ID: 20060106225420.30509.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=117437         
brade kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From brade kde org  2006-01-06 23:54 -------
SVN commit 495049 by brade:

Fix #117437. Linebreaks were not shown properly because non-rich text notes
were shown in a rich text interpreter. I wonder why it worked before, the
implementation was completely missing...

BUG: 117437


 M  +5 -2      knotes_part.cpp  
 M  +7 -2      knotes_part_p.h  


--- branches/KDE/3.5/kdepim/kontact/plugins/knotes/knotes_part.cpp #495048:495049
 @ -1,7 +1,7  @
 /*
    This file is part of the KDE project
    Copyright (C) 2002-2003 Daniel Molkentin <molkentin kde org>
-   Copyright (C) 2004 Michael Brade <brade kde org>
+   Copyright (C) 2004-2006 Michael Brade <brade kde org>
 
    This program is free software; you can redistribute it and/or
    modify it under the terms of the GNU General Public
 @ -177,7 +177,8  @
    if ( note && !force && KMessageBox::warningContinueCancelList( mNotesView,
         i18n( "Do you really want to delete this note?" ),
         mNoteList[ id ]->text(), i18n( "Confirm Delete" ),
-        KStdGuiItem::del() ) == KMessageBox::Continue ) {
+        KStdGuiItem::del() ) == KMessageBox::Continue ) 
+   {
      mManager->deleteNote( mNoteList[id]->journal() );
      mManager->save();
    }
 @ -328,6 +329,8  @
     mNoteEditDlg = new KNoteEditDlg( widget() );
 
   KCal::Journal *journal = static_cast<KNotesIconViewItem *>( item )->journal();
+
+  mNoteEditDlg->setRichText( journal->customProperty( "KNotes", "RichText" ) == "true" );
   mNoteEditDlg->setTitle( journal->summary() );
   mNoteEditDlg->setText( journal->description() );
 
--- branches/KDE/3.5/kdepim/kontact/plugins/knotes/knotes_part_p.h #495048:495049
 @ -1,6 +1,6  @
 /*
    This file is part of the KDE project
-   Copyright (C) 2004 Michael Brade <brade kde org>
+   Copyright (C) 2004-2006 Michael Brade <brade kde org>
 
    This program is free software; you can redistribute it and/or
    modify it under the terms of the GNU General Public
 @ -147,8 +147,13  @
       mTitleEdit->setText( text );
     }
 
+    void setRichText( bool rt )
+    {
+      mNoteEdit->setTextFormat( rt ? RichText : PlainText );
+    }
+
   private:
-    KLineEdit *mTitleEdit;
+    KLineEdit  *mTitleEdit;
     KNoteEdit  *mNoteEdit;
     KToolBar   *mTool;
     KPopupMenu *mEditMenu;
[prev in list] [next in list] [prev in thread] [next in thread]