[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-bugs-dist
Subject: [Bug 100465] Cookie policy for a domain gets stored but not used
From: Waldo Bastian <bastian () kde ! org>
Date: 2005-02-28 23:14:00
Message-ID: 20050228231400.23855.qmail () ktown ! kde ! org
[Download RAW message or body]
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
http://bugs.kde.org/show_bug.cgi?id=100465
bastian kde org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
------- Additional Comments From bastian kde org 2005-03-01 00:13 -------
CVS commit by waba:
Use correct domain for storing cookie policy
BUG: 100465
M +3 -10 kcookiejar.cpp 1.122
M +3 -2 kcookieserver.cpp 1.58
--- kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp #1.57:1.58
@ -560,5 +560,6 @ KCookieServer::setDomainAdvice(QString u
QStringList domains;
mCookieJar->extractDomains(fqdn, domains);
- mCookieJar->setDomainAdvice(domains[0],
+
+ mCookieJar->setDomainAdvice(domains[domains.count() > 3 ? 3 : 0],
KCookieJar::strToAdvice(advice));
// Save the cookie config if it has changed
--- kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp #1.121:1.122
@ -999,12 +999,4 @ KCookieAdvice KCookieJar::cookieAdvice(K
if (!valid)
{
- // Maybe the domain doesn't start with a "."
- QString domain = '.' + cookiePtr->domain();
- if (domains.contains(domain))
- valid = true;
- }
-
- if (!valid)
- {
// Maybe it points to a sub-domain
if (cookiePtr->domain().endsWith("."+cookiePtr->host()))
@ -1113,5 +1105,6 @ void KCookieJar::setDomainAdvice(const Q
void KCookieJar::setDomainAdvice(KHttpCookiePtr cookiePtr, KCookieAdvice _advice)
{
- QString domain = stripDomain(cookiePtr); // We file the cookie under this domain.
+ QString domain;
+ stripDomain(cookiePtr->host(), domain); // We file the cookie under this domain.
setDomainAdvice(domain, _advice);
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic