[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 35203] moving desktop icons usability issues
From:       David Faure <faure () kde ! org>
Date:       2005-01-10 19:16:53
Message-ID: 20050110191653.13497.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
        
http://bugs.kde.org/show_bug.cgi?id=35203        




------- Additional Comments From faure kde org  2005-01-10 20:16 -------
Comment #14: this has just been fixed, see bug #67140.

About the actual issue (moving by a few pixels) : Clarence and I just got this answer from qt-bugs:

"Would it be possible for you to check the applied patch. I am
considering adding this to 3.3.4 and it would be nice if you could
verify it fixed your problem and didn't introduce any bad regressions.

Basically we found the suggested patch from you:

-    if ( !i && e->source() == viewport() && d->currentItem
&& !d->cleared ) {
+    if ( (!i || (i && i == d->currentItem)) && e->source() ==
viewport() && d->currentItem && !d->cleared ) {

was to restrictive and not consistent, ie. it would only work for moving
items over the currentItem - we want to be able to move (inside the
same iconview) over any selected item. I cannot think of any sensible
usecase where one would QIconViewItem::dropped(...) to be called when
droping a selected item over itself so I can't see any bad sideeffects
with this change."

So please test this patch to see how it works for you all.
[prev in list] [next in list] [prev in thread] [next in thread]