[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 62425] Lowercasing/normalising URLs breaks some non-compliant
From:       Thiago Macieira <thiagom () mail ! com>
Date:       2003-11-23 4:27:28
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=62425     




------- Additional Comments From thiagom@mail.com  2003-11-23 05:27 -------
We have a slight problem with the current code. I've just fixed it halfway but the \
patch is not correct, so I'm not attaching anything. 

You may have noticed that Konqueror stopped caching correctly the webpages. I've \
spent a couple of hours tracing down the bug and I got it narrowed to KURL::url.

The reason for that is that the caching is handled in kio_http, but the URL is read \
from a data stream, which doesn't and cannot carry the d->uriMode variable (the wire \
format is crystallised and cannot change before KDE4, no room for updates).

That means that when HTTPProtocol::checkCacheEntry calls KURL::url to determine the \
cache, the value of d->uriMode can be undetermined and, therefore, the path name and \
query can be mishandled.

The same could also be true for other cases.

My recommendation is that operator>>(QDataStream&, KURL&) make sure that d->uriMode \
is properly set.


[prev in list] [next in list] [prev in thread] [next in thread]