[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 62425] Lowercasing/normalising URLs breaks some non-compliant
From:       Thiago Macieira <thiagom () mail ! com>
Date:       2003-08-13 14:29:48
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=62425     




------- Additional Comments From thiagom@mail.com  2003-08-13 16:29 -------
1) They are already namespace-safe because the enum is declared inside the KURL class. 
As long as nobody goes about adding methods with the same names as the enum 
constants, we'll be fine. 
 
And that won't happen because method names should always start with a lowercase letter 
(name it myFunctionLikeThis), while the enum constants start with a capital letter 
(MyEnumConstant). And we don't do underscore hell. :-) 
 
2) No, you can't change the existing constructors without breaking binary compatibility. You 
can, however, make your new constructors look like the old ones and add a comment like 
this: 
 ## BCI KDE 4.0: merge with above 
(BCI stands for Binary Compatibility Issue) 
 
The way I see it, KURL needs a cleanup for KDE 4.0. I'd actually vote for having it be 
subclassed into the different URI modes. (KURL would be a misnomer for KURI, but that's 
what is used throughout) 
 
My first glance at your code did not spot any Binary Incompatible Changes. It should be 
safe to run without rebuilding kdebase. Your problems might be caused by one of your 
earlier builds. I'll test that when I build it myself. 
 
Actually, scratch that. I've just spotted the BIC: you've added a new member variable to the 
class, increasing its size. You can't do that. Add it to the d pointer and change your uriMode
() inline function into a full one.
[prev in list] [next in list] [prev in thread] [next in thread]