[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 57275] kscd does a but wrong on gui element placing
From:       Luciano Montanaro <mikelima () virgilio ! it>
Date:       2003-04-25 10:09:38
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=57275     




------- Additional Comments From mikelima@virgilio.it  2003-04-25 12:09 -------
Subject: Re:  kscd does a but wrong on gui element placing

Alle 21:06, giovedì 24 aprile 2003, hai scritto:

> On Thursday 24 April 2003 04:41, you wrote:
> > ------- Additional Comments From mikelima@virgilio.it  2003-04-24 12:41
> > ------- I wanted to make a note about the volume slider, and found this
> > bug report. With the default keramik theme, the slider handle does not
> > fit the space available. In fact, the information panel is too crowded,
> > with the font kscd manages to get on my system, the volume label is not
> > completely readable.
> > By changing the HEIGHT variable in the drawPanel() function to 37, the
> > slider fits nicely, but as the comment there says, the function should be
> > redesigned around QGridLayout. (In fact, I have played with it for a
> > while yesterday, and I have almost redone the function. The widget are
> > almost ok, now, but the LDC panel has to be changed.
>
> patches are always welcome =)

So here it is. I am not an expert GUI programmer, but I think the attached 
patch is an improvement on the current situation. I had to experiment with
a lot of options to obtain something that seems to work. I tested it with
the keramik theme, and with all the themes supplied with KDE by default,
and I think the results are acceptable, but there is still space for 
improvement. The 'LCD display' part is still substantially the same as before 
(it has a fixed layout) but I made it a bit larger, so 'fatter' fonts and 
translated strings should have an easier life.

Ciao,
Luciano


Created an attachment (id=1434)
 --> (http://bugs.kde.org/attachment.cgi?id=1434&action=view)
kscd.patch
[prev in list] [next in list] [prev in thread] [next in thread]