[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 56682] New: KZip produces invalid ZIP files
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2003-04-01 0:20:14
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=56682     
           Summary: KZip produces invalid ZIP files
           Product: kio
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: faure@kde.org
        ReportedBy: nicolasg@snafu.de


Version:            (using KDE KDE 3.1)
Installed from:    Compiled From Sources
Compiler:          gcc 3.2 -march=pentium2
OS:          Linux

KZip produces files where the program zip refuses to add anything to them. (The \
program unzip works.)

This is in KDE_3_1_BRANCH (even last revision) and probably in CVS HEAD too.

The problem is that in KZip::closeArchive the code is:

        if ( it.current()->encoding() == 8 )
        {
            buffer[ 8 ] = 8, // general purpose bit flag, deflated
            buffer[ 10 ] = 8; // compression method, deflated
        }

But in KZip::prepareWriting the code is:
    buffer[ 8 ] = char(e->encoding()); // compression method
    buffer[ 9 ] = char(e->encoding() >> 8);

Zip complains that these too entries are different. I suppose that the code in \
KZip::closeArchive is correct, but the ZIP specification should be checked.

Have a nice day/evening/night!


[prev in list] [next in list] [prev in thread] [next in thread]