[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 49270] session management doesn't work
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2002-12-01 3:27:27
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=49270     
jfirebaugh@kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |faure@kde.org



------- Additional Comments From jfirebaugh@kde.org  2002-12-01 04:27 -------
This bug was introduced in revision 1.32 of kwritemain.cpp. The cause is calling 
KateDocument::closeURL() from queryClose(). KateDocument::closeURL() calls 
ReadWritePart::closeURL(), which first displays the "Save Changes?" dialog, and then closes the 
URL if appropriate. We want the first part, but not the second. 
 
The ideal solution is to factor out the "Save Changes?" part of ReadWritePart::closeURL() into a 
new function (suggested name: queryClose()). It probably should be virtual, but can survive 
until 4.0 without that, I think. It can then be called from both ReadWritePart::closeURL() and 
KWrite::queryClose(). 
 
Comments?
[prev in list] [next in list] [prev in thread] [next in thread]