[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 335217] New: 'Show in Media sources' no longer shows the tracks
From:       robert marshall <robert () capuchin ! co ! uk>
Date:       2014-05-22 19:58:51
Message-ID: bug-335217-71684 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=335217

            Bug ID: 335217
           Summary: 'Show in Media sources' no longer shows the tracks
    Classification: Unclassified
           Product: amarok
           Version: 2.8-git
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Collection Browser
          Assignee: amarok-bugs-dist@kde.org
          Reporter: robert@capuchin.co.uk

As a result of the fix of bug https://bugs.kde.org/show_bug.cgi?id=300557 the
build from git now no longer shows the tracks when 'Show in Media Sources' is
selected. Instead the album is displayed but the album is not opened to display
the tracks. 

From a discussion on the devel list I wrote:

 I've recently updated amarok via git and got Matěj's fix - which does
 look good. Unfortunately there's I guess a side effect (at least I
 assume the change is responsible for this) that if you - in the play
 list - click 'Show in Media Sources' before that used to open that album
 fully in sources showing all the tracks, now - for me - it opens down to
 one level (I have Album->TrackArtist sorting) and you have to move the
 mouse over to see the tracks - so the menu option doesn't actually show
 the track in media sources - you have to fiddle slightly to get it
 shown!

 Is this a necessary side effect of the fix (was the previous behaviour
 regarded as part of the 300557 bug) or do you want me to file a bug
 report?

And Matěj responded:

I think that yes, this is a side-effect. My fix revealed a bug in 
CollectionTreeView::slotCheckAutoExpand() - it does not count with the fact 
that CollectionTreeItemModel is asynchronous. Previously this bug was hidden 
because slotCheckAutoExpand() got (mistakenly) called multiple times.

The solution would be to make slotCheckAutoExpand() aware of asyncronicity of 
the model - perhaps by introducing a single-shot RAII class to expand what is 
necessary and then auto-delete itself.

Hence the filing of this bug.



Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]