[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 278897] Amarok uses ~40% of CPU until main window is maximized
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2011-11-28 11:45:05
Message-ID: E1RUzdx-0001L7-Ch () bugs ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=278897


Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Version Fixed In|                            |2.5
         Resolution|                            |FIXED




--- Comment #37 from Matěj Laitl <matej laitl cz>  2011-11-28 11:45:04 ---
Git commit 79bd9a7c6777e3f5d4e723bc5d3b00e5d6fe532b by Matěj Laitl.
Committed on 27/11/2011 at 15:24.
Pushed by laitl into branch 'master'.

Fix infinite loop in context view eating CPU until main window is shown

We used to use _scene_ sceneRect in
VerticalToolbarContainment::updateGeometry() to update applets and
geometry, but that leaded to infinite loop (across mainloop) -
m_applets->setGeometry(), refresh() would enlarge _scene_ sceneRect by
a few pixels which would trigger updateGeometry() and so on...

We now use _view_ sceneRect to update geometry. Rick W. Chen discovered
some glitches in applet collapsing when this patch is applied, but he
has a patch for that in the works and this is more serious problem, so
pushing this.

REVIEW: 103271
BUG: 278897
FIXED-IN: 2.5

M  +1    -0    ChangeLog
M  +12   -1   
src/context/containments/verticallayout/VerticalToolbarContainment.cpp

http://commits.kde.org/amarok/79bd9a7c6777e3f5d4e723bc5d3b00e5d6fe532b

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]