'[Bug 284838] Amarok Crashed while trying to copy album of mp3s from'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 284838] Amarok Crashed while trying to copy album of mp3s from
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2011-10-28 15:21:43
Message-ID: E1RJoFb-00021P-1l () bugs ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=284838

Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |2.5
         Resolution|                            |FIXED

--- Comment #2 from Matěj Laitl <matej laitl cz>  2011-10-28 15:21:42 ---
Git commit b39551b9791203b952b30108cbdaea28e4871494 by Matěj Laitl.
Committed on 28/10/2011 at 17:09.
Pushed by laitl into branch 'master'.

MediaDeviceTrack: prevent possible crashes, Handler::Capability fixes

When a media device is removed, its collection and handler are
destroyed, but its tracks, albums are kept as long as they are
referenced. Tracks, albums use QWeakPointer to track deletion of
their handler. Ensure that this pointer is always checked before
use in MediaDeviceTrack.

Also ensure that related Capabilities get destroyed (they should
be alredy tracked using QWeakPointer) when handler gets deleted.
It did not work previously in cases when Capabilities were created
in a thread from handler's. Move them to handler's thread so that
parentship can be established.

BUG: 284838
FIXED-IN: 2.5

M  +1    -0    ChangeLog
M  +26   -18  
src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp
M  +10   -0   
src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.cpp
M  +3    -4   
src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.h

http://commits.kde.org/amarok/b39551b9791203b952b30108cbdaea28e4871494

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread] 