[prev in list] [next in list] [prev in thread] [next in thread] 

List:       zope-dev
Subject:    Re: [Zope-dev] zope-tests - FAILED: 5, OK: 19
From:       Patrick Gerken <do3ccqrv () googlemail ! com>
Date:       2012-12-28 12:02:55
Message-ID: CAFefbnH-sqVOVFAB5AO7f2Pe=D3pXGnjUpVJTGMZ1F2sNvebYQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


[1]    FAILED  Still Failing - zopetoolkit_trunk - Build # 119

>
> https://mail.zope.org/pipermail/zope-tests/2012-December/070665.html
>


>
>
> [2]    FAILED  Still Failing - zopetoolkit_trunk_app - Build # 103
>
> https://mail.zope.org/pipermail/zope-tests/2012-December/070666.html
>

This should stop failing now. I updated the svn:ignore properties in
zope.security to fix it.

>
>
> [3]    FAILED  winbot / BTrees_py_265_32
>
> https://mail.zope.org/pipermail/zope-tests/2012-December/070686.html
>

The tests only work with 64 bit. I only debugged code partially, but thats
what I found:
- a abs() method that does number &= 0x7fffffffffffffff. I was able to
replace that with sys.maxint to work on 32 bit
- One test wanted to test for value errors on a method by providing
sys.maxint + 1. The method used struct pack and unpack to ensure the
variable is not too big. struct pack and unpack work with the same
datasizes on 32 bit and 64 bit.
I THINK the tests should be rewritten to use unpack to generate maxint, but
I am not sure and hope somebody more knowledgeable than me can give his
opinion here.


>
> [4]    FAILED  winbot / z3c.ptcompat_py_265_32
>
> https://mail.zope.org/pipermail/zope-tests/2012-December/070663.html
>

Formatted output differs in whitespaces and newlines.
z3c.ptcompat runs the test from zope.pagetemplates, the tests generate a
different result than in zope.pagetemplates, because after z3c.ptcompat is
installed, the renderer is chameleon. The tests that render differently in
chameleon are new, thats why the tests fail even if nothing changed in
z3c.ptcompat.
It seems chameleon generates too many newlines for a tal repeat statement,
in the output, it contains 2 newlines after each iteration. Does a
chameleon developer read these mails and might want to comment?

This is the input:
<!-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 -->
<ul metal:define-macro="tree">
  <li tal:content="context/name" />
  <li tal:repeat="context context/children">
    <ul metal:use-macro="template/macros/tree" />
  </li>
</ul>

and this the output:
<!-- See https://bugs.launchpad.net/zope.pagetemplate/+bug/732972 -->
<ul>
 <li>root</li>
 <li>
 <ul>
 <li>first</li>

</ul>
 </li>
 <li>
 <ul>
 <li>second</li>

</ul>
 </li>
</ul>


>
> [5]    FAILED  winbot / z3c.recipe.paster_py_265_32
>
> https://mail.zope.org/pipermail/zope-tests/2012-December/070664.html
>

The tests try to run a buildout in a fake root. I have the same problem
under linux with python 2.7 64 bit. When I kill the test, go to the temp
dir and run the buildout, all works fine, so this might be related to the
fakeroot functionality from buildout. Maybe somebody who knows about that
functionality of buildout could take a look?


_______________________________________________
> Zope-Dev maillist  -  Zope-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>

[Attachment #5 (text/html)]

<div dir="ltr"><font face="courier new,monospace"><br></font><div \
class="gmail_extra"><br><br><div class="gmail_quote">[1]      FAILED   Still Failing \
- zopetoolkit_trunk - Build # 119<br><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">


           <a href="https://mail.zope.org/pipermail/zope-tests/2012-December/070665.html" \
target="_blank">https://mail.zope.org/pipermail/zope-tests/2012-December/070665.html</a><br></blockquote><div> \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px \
solid rgb(204,204,204);padding-left:1ex">


<br>
<br>
[2]      FAILED   Still Failing - zopetoolkit_trunk_app - Build # 103<br>
           <a href="https://mail.zope.org/pipermail/zope-tests/2012-December/070666.html" \
target="_blank">https://mail.zope.org/pipermail/zope-tests/2012-December/070666.html</a><br></blockquote><div><br></div><div>This \
should stop failing now. I updated the svn:ignore properties in zope.security to fix \
it.<br>

</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px \
solid rgb(204,204,204);padding-left:1ex"> <br>
<br>
[3]      FAILED   winbot / BTrees_py_265_32<br>
           <a href="https://mail.zope.org/pipermail/zope-tests/2012-December/070686.html" \
target="_blank">https://mail.zope.org/pipermail/zope-tests/2012-December/070686.html</a><br></blockquote><div><br></div><div>The \
tests only work with 64 bit. I only debugged code partially, but thats what I \
found:<br>

</div><div>- a abs() method that does number &amp;= 0x7fffffffffffffff. I was able to \
replace that with sys.maxint to work on 32 bit<br></div><div>- One test wanted to \
test for value errors on a method by providing sys.maxint + 1. The method used struct \
pack and unpack to ensure the variable is not too big. struct pack and unpack work \
with the same datasizes on 32 bit and 64 bit.<br>

</div><div>I THINK the tests should be rewritten to use unpack to generate maxint, \
but I am not sure and hope somebody more knowledgeable than me can give his opinion \
here.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px \
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">


<br>
<br>
[4]      FAILED   winbot / z3c.ptcompat_py_265_32<br>
           <a href="https://mail.zope.org/pipermail/zope-tests/2012-December/070663.html" \
target="_blank">https://mail.zope.org/pipermail/zope-tests/2012-December/070663.html</a><br></blockquote><div><br></div><div>Formatted \
output differs in whitespaces and newlines.<br>

</div><div>z3c.ptcompat runs the test from zope.pagetemplates, the tests generate a \
different result than in zope.pagetemplates, because after z3c.ptcompat is installed, \
the renderer is chameleon. The tests that render differently in chameleon are new, \
thats why the tests fail even if nothing changed in z3c.ptcompat.<br>

</div><div>It seems chameleon generates too many newlines for a tal repeat statement, \
in the output, it contains 2 newlines after each iteration. Does a chameleon \
developer read these mails and might want to comment?<br> </div>
<div><br>This is the input:<br>&lt;!-- See <a \
href="https://bugs.launchpad.net/zope.pagetemplate/+bug/732972">https://bugs.launchpad.net/zope.pagetemplate/+bug/732972</a> \
--&gt;<br>&lt;ul metal:define-macro=&quot;tree&quot;&gt;<br>

   &lt;li tal:content=&quot;context/name&quot; /&gt;<br>   &lt;li \
tal:repeat=&quot;context context/children&quot;&gt;<br>       &lt;ul \
metal:use-macro=&quot;template/macros/tree&quot; /&gt;<br>   \
&lt;/li&gt;<br>&lt;/ul&gt;<br> <br>
</div><div>and this the output:<br>&lt;!-- See <a \
href="https://bugs.launchpad.net/zope.pagetemplate/+bug/732972">https://bugs.launchpad.net/zope.pagetemplate/+bug/732972</a> \
--&gt;<br>&lt;ul&gt;<br>  &lt;li&gt;root&lt;/li&gt;<br>

  &lt;li&gt;<br>  &lt;ul&gt;<br>  &lt;li&gt;first&lt;/li&gt;<br>  <br>&lt;/ul&gt;<br> \
&lt;/li&gt;<br>  &lt;li&gt;<br>  &lt;ul&gt;<br>  &lt;li&gt;second&lt;/li&gt;<br>  \
<br>&lt;/ul&gt;<br>  &lt;/li&gt;<br>&lt;/ul&gt;<br><br></div> <blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">

<br>
<br>
[5]      FAILED   winbot / z3c.recipe.paster_py_265_32<br>
           <a href="https://mail.zope.org/pipermail/zope-tests/2012-December/070664.html" \
target="_blank">https://mail.zope.org/pipermail/zope-tests/2012-December/070664.html</a><br></blockquote><div><br></div><div>The \
tests try to run a buildout in a fake root. I have the same problem under linux with \
python 2.7 64 bit. When I kill the test, go to the temp dir and run the buildout, all \
works fine, so this might be related to the fakeroot functionality from buildout. \
Maybe somebody who knows about that functionality of buildout could take a look?<br>

<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> \
_______________________________________________<br> Zope-Dev maillist   -   <a \
href="mailto:Zope-Dev@zope.org">Zope-Dev@zope.org</a><br> <a \
href="https://mail.zope.org/mailman/listinfo/zope-dev" \
                target="_blank">https://mail.zope.org/mailman/listinfo/zope-dev</a><br>
                
**   No cross posts or HTML encoding!   **<br>
(Related lists -<br>
  <a href="https://mail.zope.org/mailman/listinfo/zope-announce" \
target="_blank">https://mail.zope.org/mailman/listinfo/zope-announce</a><br>  <a \
href="https://mail.zope.org/mailman/listinfo/zope" \
target="_blank">https://mail.zope.org/mailman/listinfo/zope</a> )<br> \
</blockquote></div><br></div></div>



_______________________________________________
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic