[prev in list] [next in list] [prev in thread] [next in thread]
List: zope-dev
Subject: Re: [Zope-dev] Re: [Checkins] SVN: Zope/trunk/ Added
From: Andreas Jung <lists () zopyx ! com>
Date: 2007-10-20 9:29:49
Message-ID: F14B63561EC6E65867015063 () [192 ! 168 ! 0 ! 24]
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
--On 20. Oktober 2007 11:20:09 +0200 Hanno Schlichting
<plone@hannosch.info> wrote:
> Hi.
>
> Christian Theune wrote:
>> Cool,
>>
>> Am Dienstag, den 16.10.2007, 17:16 -0400 schrieb Hanno Schlichting:
>>> Log message for revision 80896:
>>> Added LAZY_FILE_LOADING constant to PageTemplateFile. When set to
>>> True Page Template files aren't lo aded and parsed on Zope startup
>>> anymore, but on first access instead. When complex add-ons like Plon
>>> e are installed this can safe up to 30% of the Zope startup time.
>>> This gets a ZConfig switch ones I figured out how to write one ;)
>>>
>>> Modified:
>>> Zope/trunk/lib/python/Products/PageTemplates/PageTemplateFile.py
>>> =================================================================== ---
>>> Zope/trunk/lib/python/Products/PageTemplates/PageTemplateFile.py
>>> 2007-10-16 20:12:30 UTC (rev 80895) +++
>>> Zope/trunk/lib/python/Products/PageTemplates/PageTemplateFile.py
>>> 2007-10-16 21:16:07 UTC (rev 80896) @@ -31,6 +31,8 @@
>>>
>>> LOG = getLogger('PageTemplateFile')
>>>
>>> +LAZY_FILE_LOADING = False
>>> +
>>> def guess_type(filename, text):
>>
>>
>> Hmm. Maybe an option that can actually be configured would be better?
>> What about adding an option to zope.conf?
>>
>> And why don't we enable it by default? At least for debug mode?
>
> After looking at this again, I realized that the zope.pagetemplates
> version does not load the file content on __init__ at all.
>
> I would suggest to change the Products.PageTemplates version in the same
> way, making lazy loading the default, without any configurable option.
>
> Thoughts?
I would say: go ahead.
Andreas
[Attachment #5 (application/pgp-signature)]
_______________________________________________
Zope-Dev maillist - Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic