[prev in list] [next in list] [prev in thread] [next in thread] 

List:       zope-dev
Subject:    Re: [Zope-dev] Bug in Traversable.py
From:       "Lennart Regebro" <regebro () gmail ! com>
Date:       2007-03-29 6:37:59
Message-ID: 319e029f0703282337m4d0e384fs904a5d35c71852cc () mail ! gmail ! com
[Download RAW message or body]

On 3/23/07, Roché Compaan <roche@upfrontsystems.co.za> wrote:
> Thus, often string attributes will fail with this check.

I don't understand how you reach that conclusion.

> In my opinion the code should read:
>
>                             if not ok:
>                                 if (container is not None or
>                                     guarded_getattr(obj, name, _marker)
>                                         != next):
>                                     raise Unauthorized(name)

No, we are checking for identity there, because that's what we want to
check. The question is why guarded_getattr(obj, name, _marker) and
bobo_traverse(REQUEST, name) doesn't return the same object in this
case.

> If you agree that his is a bug, I'll log it.

I suspect that the bug is something different than this.

-- 
Lennart Regebro: Zope and Plone consulting.
http://www.colliberty.com/
+33 661 58 14 64
_______________________________________________
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )

[prev in list] [next in list] [prev in thread] [next in thread]