[prev in list] [next in list] [prev in thread] [next in thread] 

List:       zope-cvs
Subject:    [Zope-Checkins]
From:       Lennart Regebro <regebro () nuxeo ! com>
Date:       2004-11-26 18:45:37
Message-ID: 20041126184537.CA8B620324B () mail ! zope ! org
[Download RAW message or body]

Log message for revision 28526:
  bin/zopectl test now uses os.execv, instead os os.system, so that options with \
characters that needs shell quoting doesn't break the command.  

Changed:
  U   Zope/trunk/doc/CHANGES.txt
  U   Zope/trunk/lib/python/Zope/Startup/zopectl.py

-=-
Modified: Zope/trunk/doc/CHANGES.txt
===================================================================
--- Zope/trunk/doc/CHANGES.txt	2004-11-26 18:27:43 UTC (rev 28525)
+++ Zope/trunk/doc/CHANGES.txt	2004-11-26 18:45:37 UTC (rev 28526)
@@ -46,6 +46,10 @@
 
     Bugs fixed
     
+      - bin/zopectl test now uses os.execv, instead os os.system,
+        so that options with characters that needs shell quoting
+        doesn't break the command.
+      
       - Collector #945:  Allow adding empty PythonScript instances
         programmatically.
 

Modified: Zope/trunk/lib/python/Zope/Startup/zopectl.py
===================================================================
--- Zope/trunk/lib/python/Zope/Startup/zopectl.py	2004-11-26 18:27:43 UTC (rev 28525)
+++ Zope/trunk/lib/python/Zope/Startup/zopectl.py	2004-11-26 18:45:37 UTC (rev 28526)
@@ -254,10 +254,10 @@
             args.insert(0, '-v')
 
         args.insert(0, script)
+        args.insert(0, self.options.python)
 
-        cmdline = ' '.join([self.options.python] + args)
-        print 'Running tests via: %s' % cmdline
-        os.system(cmdline)
+        print 'Running tests via: %s' % ' '.join(args)
+        os.execv(self.options.python, args)
 
     def help_test(self):
         print "test [args]+ -- run unit / functional tests."

_______________________________________________
Zope-Checkins maillist  -  Zope-Checkins@zope.org
http://mail.zope.org/mailman/listinfo/zope-checkins


[prev in list] [next in list] [prev in thread] [next in thread]