[prev in list] [next in list] [prev in thread] [next in thread] 

List:       zope-cmf
Subject:    [Zope-CMF] Skinnable bare except
From:       Florent Guillaume <fg () nuxeo ! com>
Date:       2005-04-22 15:19:18
Message-ID: 426915F6.2060709 () nuxeo ! com
[Download RAW message or body]

SkinnableObjectManager.__of__ has this code:

        try:
            w_self.setupCurrentSkin()
        except:
            # This shouldn't happen, even if the requested skin
            # does not exist.
            import sys
            from zLOG import LOG, ERROR
            LOG('CMFCore', ERROR, 'Unable to setupCurrentSkin()',
                error=sys.exc_info())

In an application we're seeing many ConflictErrors wrongly catched here.
I'm changing it to at least reraise the ConflictError directly.

Florent

-- 
Florent Guillaume, Nuxeo (Paris, France)   CTO, Director of R&D
+33 1 40 33 71 59   http://nuxeo.com   fg@nuxeo.com
_______________________________________________
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests
[prev in list] [next in list] [prev in thread] [next in thread]