[prev in list] [next in list] [prev in thread] [next in thread] 

List:       zodb-checkins
Subject:    [Zodb-checkins] CVS: ZODB3/ZEO - ClientStorage.py:1.116
From:       Jeremy Hylton <jeremy () zope ! com>
Date:       2003-12-30 22:57:36
Message-ID: 200312302257.hBUMvam3018517 () cvs ! zope ! org
[Download RAW message or body]

Update of /cvs-repository/ZODB3/ZEO
In directory cvs.zope.org:/tmp/cvs-serv18498

Modified Files:
	ClientStorage.py 
Log Message:
Yes.  It should.

Move setLastTid() call into block where lock is held.


=== ZODB3/ZEO/ClientStorage.py 1.115 => 1.116 ===
--- ZODB3/ZEO/ClientStorage.py:1.115	Tue Dec 30 17:29:27 2003
+++ ZODB3/ZEO/ClientStorage.py	Tue Dec 30 17:57:35 2003
@@ -960,12 +960,11 @@
             self._lock.acquire()  # for atomic processing of invalidations
             try:
                 self._update_cache(tid)
+                self._cache.setLastTid(tid)
                 if f is not None:
                     f(tid)
             finally:
                 self._lock.release()
-            # XXX Shouldn't this cache call be made while holding the lock?
-            self._cache.setLastTid(tid)
 
             r = self._check_serials()
             assert r is None or len(r) == 0, "unhandled serialnos: %s" % r


_______________________________________________
Zodb-checkins mailing list
Zodb-checkins@zope.org
http://mail.zope.org/mailman/listinfo/zodb-checkins
[prev in list] [next in list] [prev in thread] [next in thread]