[prev in list] [next in list] [prev in thread] [next in thread] 

List:       zeromq-dev
Subject:    Re: [zeromq-dev] zyre chat example
From:       Michel Pelletier <pelletier.michel () gmail ! com>
Date:       2014-08-28 15:12:24
Message-ID: CACxu=vKD24hfcSF3G_DQ3uXkxwXWiaXH+HOZQrod2NEVkoGk6g () mail ! gmail ! com
[Download RAW message or body]

On Thu, Aug 28, 2014 at 7:54 AM, Chad Koski <chad@koski.com> wrote:
> Hi All,
> 
> I've rewritten the zyre chat example to use a zactor instead of zthread.   Why? The \
> chat program isn't working as-is (at least not for me).  When I started digging in, \
> I saw the comments in zactor.c indicating that this class is intended to replace \
> the the zthread class for normal use.  Rather than struggle with the deprecated \
> code, I rewrote the sample in terms of the new model, and it works now. 
> Is this something of interest to the community?  If so, should I replace the \
> existing chat example, or add a new example to the project?  Sorry if the question \
> is obvious or basic.  Just trying to get it correct before I create a pull request \
> (if anyone wants it of course)

Awesome!  Yes please PR it.

My opinion is to axe the old one.  If someone wants to revive it they
can always make a new PR.  As it was broken anyway, perhaps for some
time, I don't think anyone will notice.

-Michel

> 
> Thanks,
> Chad
> 
> _______________________________________________
> zeromq-dev mailing list
> zeromq-dev@lists.zeromq.org
> http://lists.zeromq.org/mailman/listinfo/zeromq-dev
_______________________________________________
zeromq-dev mailing list
zeromq-dev@lists.zeromq.org
http://lists.zeromq.org/mailman/listinfo/zeromq-dev


[prev in list] [next in list] [prev in thread] [next in thread]