[prev in list] [next in list] [prev in thread] [next in thread] 

List:       yaffs
Subject:    [Yaffs]  Checking for ecc_result == -YAFFS_ECC_RESULT_FIXED
From:       Mykelyk <mykelyk () gmail ! com>
Date:       2012-11-20 3:53:41
Message-ID: CACtTeSBa8F1opmpc3aJNYSHC7_vFrKVfLttC-WsoCr1ix9dZ2A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

in the file yaffs_tagsmarshall.c on the line 121-125:

if (tags && ecc_result == -YAFFS_ECC_RESULT_FIXED) {
if (tags->ecc_result <= YAFFS_ECC_RESULT_NO_ERROR)
tags->ecc_result = YAFFS_ECC_RESULT_FIXED;
dev->n_ecc_fixed++;
}

Should not be checking for YAFFS_ECC_RESULT_FIXED (without the minus sign)
instead? I cannot find in the code any other instance of negative
ecc_result.

Best regards
Michele Artoni

[Attachment #5 (text/html)]

Hi,<div><br><div>in the file yaffs_tagsmarshall.c on the line \
121-125:<div><br></div><div><div><span class="" style="white-space:pre">	</span>if \
(tags &amp;&amp; ecc_result == -YAFFS_ECC_RESULT_FIXED) {</div><div><span class="" \
style="white-space:pre">		</span>if (tags-&gt;ecc_result &lt;= \
YAFFS_ECC_RESULT_NO_ERROR)</div> <div><span class="" \
style="white-space:pre">			</span>tags-&gt;ecc_result = \
YAFFS_ECC_RESULT_FIXED;</div><div><span class="" \
style="white-space:pre">		</span>dev-&gt;n_ecc_fixed++;</div><div><span class="" \
style="white-space:pre">	</span>}</div> </div></div></div><div><br></div><div>Should \
not be checking for  YAFFS_ECC_RESULT_FIXED (without the minus sign) instead? I \
cannot find in the code any other instance of negative \
ecc_result.</div><div><br></div><div>Best regards</div> <div>Michele Artoni</div>



_______________________________________________
yaffs mailing list
yaffs@lists.aleph1.co.uk
http://lists.aleph1.co.uk/cgi-bin/mailman/listinfo/yaffs


[prev in list] [next in list] [prev in thread] [next in thread]