[prev in list] [next in list] [prev in thread] [next in thread] 

List:       yaffs
Subject:    Re: [Yaffs] [PATCH YAFFS2] yaffs1-ecc-fix
From:       Artis Kugevics <artis () mikrotik ! com>
Date:       2005-08-03 8:31:34
Message-ID: 200508031131.34987.artis () mikrotik ! com
[Download RAW message or body]

On Tuesday 02 August 2005 22:22, Luc Van Oostenryck wrote:
> Artis Kugevics wrote:
> > Hello,
> >
> > I highly recommend adding this patch to yaffs2 for it to work correctly
> > with yaffs1 partitions.
> > It is required to specify eccbytes for current MTD version, otherwise ECC
> > will fail.
> > It is required to check return value after mtd->write_ecc() call,
> > otherwise write failures will not be detected.
> >
> > Thanks,
> > -Artis
>
> It's in CVS now.
>
> Many thanks.

I'm glad to see it :) Thanks!

But my original patch was a bit modified - CONFIG_YAFFS_USE_OLD_MTD is taken 
out. As I understand, yaffs2 does not support old MTD version anymore. So, 
probably .eccbytes should be included all the time (without any #if 
check)...?
Current check for kernel version will not work for those, who have backported 
MTD to 2.4 kernel (as I have done). Of course, I can maintain my own changes, 
but question is - whether it is needed?

Thanks,
Artis

>
>
> Luc


[prev in list] [next in list] [prev in thread] [next in thread]