[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xwt-patches
Subject:    Re: [patches] self-contained launcher
From:       Adam Megacz <adam () xwt ! org>
Date:       2003-04-30 10:11:00
[Download RAW message or body]


Hey, great stuff, Emiliano..


Emiliano <emile@iris-advies.nl> writes:
> --- dist/update	<new>
> +++ dist/update	Sat Apr 26 18:04:16 2003
> @@ -0,0 +1,14 @@
> +#!/bin/sh
> +wget -N http://dist.xwt.org/mappings.txt
> +for d in `grep : mappings.txt | awk '{print $2}'` ; do
> +    wget -N http://dist.xwt.org/xwt-$d.jar
> +    wget -N http://dist.xwt.org/xwt-$d.cab
> +    wget -N http://dist.xwt.org/xwt-$d.exe.gz
> +    wget -N http://dist.xwt.org/xwt-$d.linux.gz
> +    wget -N http://dist.xwt.org/shoehorn-$d.jar
> +done
> +wget -N http://dist.xwt.org/xwt.jar
> +wget -N http://dist.xwt.org/xwt.cab
> +wget -N http://dist.xwt.org/shoehorn.jar

Could we make this part of 'make launcher.war/jar', and wrap the
exe/jar/cab up into the war/jar file?



> +	cd dist; cp `cat files` ../war

what is dist/files?  where does it come from?


> +update:
> +	cd dist; ./update

Could you move the update script into the Makefile?  It really doesn't
need to be a seperate file.



> +    // Global config //////////////////////////////////////////////////////////////////////////////
> +    public static String launcherURI = "/";

Like I said before, we should autodetect this.


> +            for (int i=0; i<args.length; i++) {
> +                eq = args[i].indexOf('=');

Could we use unixoid "-option foo" rather than "option=foo"?


> +                    } else if (key.equals("url")) {
> +                        xwarUrlPrefix = value;

I don't think this needs to be configurable...


> +        String engine = path.substring(0, path.indexOf('/'));
> +
> +        if (engine == null) {
>              pw.println("<html><body><p>Error: couldn't parse engine name</p></body></html>");
>              return;
>          }

We need to return a 404 here if the engine was null or wasn't in
mappings and wasn't a four-digit hexstring.



> +        path = path.substring(path.indexOf('/') + 1);
> +        // ServletRequest seems to filter out double slashes, so :// gets flattened to :/
> +        if (path.indexOf(":/") != -1) {
> +        	path = replace(path, ":/", "://");
> +        } else {
> +        	path = "http://" + path;
> +        }

Very cool.


> +        param = servletConfig.getInitParameter("autoConfig");
> +        if (param != null && param.equals("true")) {
> +            autoConfig = true;
> +            context = servletConfig.getServletContext();

I'd vote for making autoConfig mandatory; ie remove support for not
having it.


> -        <url-pattern>  /* </url-pattern>
> +        <url-pattern>/go/*</url-pattern>

I don't quite understand this...

  - a

[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic