[prev in list] [next in list] [prev in thread] [next in thread]
List: xmonad
Subject: Re: [xmonad] [xmonad-contrib] Patch to add messages IncSpacing/SetSpacing to the Spacing modifier fo
From: adam vogt <vogt.adam () gmail ! com>
Date: 2015-03-10 20:58:51
Message-ID: CAHfjoW=1fMPwUD0XoFTqmf68eWFA9WCOFya5AhAMkZ9w1Eb-9Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Anton
Don't worry, the plan is to include it. I have made some changes to it
(such as passing -format "%w %h" to identify, so we don't need splitOn and
the text package to parse the output). I'll push it once I've checked that
I haven't broken wallpaper setter.
Thanks
Adam
On Mar 10, 2015 4:25 PM, "Anton Pirogov" <anton.pirogov@gmail.com> wrote:
> Thanks!
>
> As you seem to be someone who can include patches.. Could you tell me,
> what is about my WallpaperSetter Hook? It it rejected? If yes, for which
> reason exactly? Is it because it relies on external tools? (but so does
> also for example Util.Dmenu and imagemagick is a quite "standard" tool in
> my opinion). I think it is a generally useful addition and there is some
> concrete fixable problem with it I am not aware of I could work on it.
>
> Regards,
> Anton
>
>
> 2015-03-10 19:28 GMT+01:00 adam vogt <vogt.adam@gmail.com>:
>
>> Thanks Anton,
>>
>> I've pushed the patch.
>>
>> Unfortunately I've made a bit of a mess of the history by including both
>> patches, and then needing to address the conflicts with another patch.
>>
>> Regards,
>> Adam
>>
>> On Wed, Mar 4, 2015 at 3:36 AM, Anton Pirogov <anton.pirogov@gmail.com>
>> wrote:
>>
>>> Hi Adam,
>>>
>>> thank you for your suggestions! Indeed I didn't need those instances and
>>> I changed the message to your more flexible idea!
>>>
>>> I don't know what is the right way to do it here and with darcs in
>>> general, I used "darcs obliterate --last 1" and recorded a new patch. Here
>>> is the updated patch, I hope it is ok now.
>>>
>>> Regards,
>>> Anton
>>>
>>> 2015-03-04 1:03 GMT+01:00 adam vogt <vogt.adam@gmail.com>:
>>>
>>>> Hi Anton,
>>>>
>>>> Do you actually need the Read/Show instances? I think it's better to
>>>> put a function in the message:
>>>>
>>>> data ModifySpacing = ModifySpacing (Int -> Int)
>>>>
>>>> And possibly export these convenience functions:
>>>>
>>>> setSpacing n = sendMessage (ModifySpacing (\_ -> n))
>>>> incSpacing n = sendMessage (ModifySpacing (+n))
>>>>
>>>> Regards,
>>>> Adam
>>>>
>>>> On Tue, Mar 3, 2015 at 4:09 PM, Anton Pirogov <anton.pirogov@gmail.com>
>>>> wrote:
>>>> > This is such a small change that I think that it makes more sense to
>>>> patch
>>>> > it, instead of rolling my own. It just adds the message, nothing
>>>> more, so it
>>>> > does not break anything.
>>>> >
>>>> > Thanks!
>>>> >
>>>> > Best regards,
>>>> > Anton Pirogov
>>>> >
>>>> > _______________________________________________
>>>> > xmonad mailing list
>>>> > xmonad@haskell.org
>>>> > http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
>>>> >
>>>>
>>>
>>>
>>> _______________________________________________
>>> xmonad mailing list
>>> xmonad@haskell.org
>>> http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
>>>
>>>
>>
>
[Attachment #5 (text/html)]
<p dir="ltr">Hi Anton</p>
<p dir="ltr">Don't worry, the plan is to include it. I have made some changes to \
it (such as passing -format "%w %h" to identify, so we don't need \
splitOn and the text package to parse the output). I'll push it once I've \
checked that I haven't broken wallpaper setter.</p> <p dir="ltr">Thanks<br>
Adam</p>
<div class="gmail_quote">On Mar 10, 2015 4:25 PM, "Anton Pirogov" <<a \
href="mailto:anton.pirogov@gmail.com">anton.pirogov@gmail.com</a>> wrote:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks!<br><br>As \
you seem to be someone who can include patches.. Could you tell me, what is about my \
WallpaperSetter Hook? It it rejected? If yes, for which reason exactly? Is it because \
it relies on external tools? (but so does also for example Util.Dmenu and imagemagick \
is a quite "standard" tool in my opinion). I think it is a generally useful \
addition and there is some concrete fixable problem with it I am not aware of I could \
work on it.<br><br>Regards,<br>Anton<br><br></div><div class="gmail_extra"><br><div \
class="gmail_quote">2015-03-10 19:28 GMT+01:00 adam vogt <span dir="ltr"><<a \
href="mailto:vogt.adam@gmail.com" \
target="_blank">vogt.adam@gmail.com</a>></span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Thanks Anton,<br><br>I've pushed the \
patch.<br><br>Unfortunately I've made a bit of a mess of the history by including \
both patches, and then needing to address the conflicts with another \
patch.<br><br>Regards,<br>Adam<br></div><div><div><div class="gmail_extra"><br><div \
class="gmail_quote">On Wed, Mar 4, 2015 at 3:36 AM, Anton Pirogov <span \
dir="ltr"><<a href="mailto:anton.pirogov@gmail.com" \
target="_blank">anton.pirogov@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><span>Hi Adam,<br><br>thank you for your \
suggestions! Indeed I didn't need those instances and I changed the message to \
your more flexible idea!<br><br>I don't know what is the right way to do it here \
and with darcs in general, I used "darcs obliterate --last 1" and recorded \
a new patch. Here is the updated patch, I hope it is ok \
now.<br><br>Regards,<br>Anton</span><div class="gmail_extra"><br><div \
class="gmail_quote"><span>2015-03-04 1:03 GMT+01:00 adam vogt <span dir="ltr"><<a \
href="mailto:vogt.adam@gmail.com" \
target="_blank">vogt.adam@gmail.com</a>></span>:<br></span><div><div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Anton,<br> <br>
Do you actually need the Read/Show instances? I think it's better to<br>
put a function in the message:<br>
<br>
data ModifySpacing = ModifySpacing (Int -> Int)<br>
<br>
And possibly export these convenience functions:<br>
<br>
setSpacing n = sendMessage (ModifySpacing (\_ -> n))<br>
incSpacing n = sendMessage (ModifySpacing (+n))<br>
<br>
Regards,<br>
Adam<br>
<div><div><br>
On Tue, Mar 3, 2015 at 4:09 PM, Anton Pirogov <<a \
href="mailto:anton.pirogov@gmail.com" target="_blank">anton.pirogov@gmail.com</a>> \
wrote:<br> > This is such a small change that I think that it makes more sense to \
patch<br> > it, instead of rolling my own. It just adds the message, nothing more, \
so it<br> > does not break anything.<br>
><br>
> Thanks!<br>
><br>
> Best regards,<br>
> Anton Pirogov<br>
><br>
</div></div>> _______________________________________________<br>
> xmonad mailing list<br>
> <a href="mailto:xmonad@haskell.org" target="_blank">xmonad@haskell.org</a><br>
> <a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad" \
target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad</a><br> \
><br> </blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
xmonad mailing list<br>
<a href="mailto:xmonad@haskell.org" target="_blank">xmonad@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad" \
target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad</a><br> \
<br></blockquote></div><br></div> </div></div></blockquote></div><br></div>
</blockquote></div>
_______________________________________________
xmonad mailing list
xmonad@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic