[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xmonad
Subject:    Re: [xmonad] Added a new simple layout
From:       Brandon Allbery <allbery.b () gmail ! com>
Date:       2014-12-15 15:50:27
Message-ID: CAKFCL4V_UfdAUVto+K-4D0+xDOsMH25d7ZN1GM4J4vhr7eHmfQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, Dec 12, 2014 at 12:10 PM, Norbert Zeh <nzeh@cs.dal.ca> wrote:
>
> ... and thought I'd share.  Patch is attached.
>

A few nits:

- the comment in XMonad.Layout.Dwindle identifies it as XMonad.Layout.Spiral

- consider renaming Rotation, as anyone using your module must also import
XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

-- 
brandon s allbery kf8nh                               sine nomine associates
allbery.b@gmail.com                                  ballbery@sinenomine.net
unix, openafs, kerberos, infrastructure, xmonad        http://sinenomine.net

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 12, 2014 \
at 12:10 PM, Norbert Zeh <span dir="ltr">&lt;<a href="mailto:nzeh@cs.dal.ca" \
target="_blank">nzeh@cs.dal.ca</a>&gt;</span> wrote:<blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div \
dir="ltr">... and thought I&#39;d share.   Patch is \
attached.<br></div></blockquote><div><br></div><div>A few \
nits:</div><div><br></div><div>- the comment in XMonad.Layout.Dwindle identifies it \
as XMonad.Layout.Spiral</div><div><br></div><div>- consider renaming Rotation, as \
anyone using your module must also import XMonad hiding (Rotation). At the very \
least, you should document the requirement if you&#39;re going to keep it, since you \
export it. Possible alternate name: Chirality.</div></div><div><br></div>-- <br><div \
class="gmail_signature"><div dir="ltr"><div>brandon s allbery kf8nh                   \
sine nomine associates</div><div><a href="mailto:allbery.b@gmail.com" \
target="_blank">allbery.b@gmail.com</a>                                               \
<a href="mailto:ballbery@sinenomine.net" \
target="_blank">ballbery@sinenomine.net</a></div><div>unix, openafs, kerberos, \
infrastructure, xmonad            <a href="http://sinenomine.net" \
target="_blank">http://sinenomine.net</a></div></div></div> </div></div>



_______________________________________________
xmonad mailing list
xmonad@haskell.org
http://www.haskell.org/mailman/listinfo/xmonad


[prev in list] [next in list] [prev in thread] [next in thread]