[prev in list] [next in list] [prev in thread] [next in thread]
List: xmonad
Subject: Re: [xmonad] Workspace ordering and DynamicWorkspaces (+ patch)
From: Hans Chen <hanswchen () gmail ! com>
Date: 2013-01-08 3:05:45
Message-ID: CAFfzviBx3ZWCO4iZujLrMHDUBJB55x929ZrjijmVO8kGF-8a8w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Adam,
Thank you so much for your answer! Hopefully people will chime in if
they're negatively affected by the patch.
Thanks,
Hans
On Sun, Jan 6, 2013 at 9:55 PM, adam vogt <vogt.adam@gmail.com> wrote:
> On Sun, Jan 6, 2013 at 6:27 PM, Hans Chen <hanswchen@gmail.com> wrote:
> > I use DynamicWorkspaces with a few predefined workspaces. The problem is
> > that when creating a new workspace, it gets sorted before my predefined
> > workspaces and thus I can't always have e.g. "web" on Mod+1.
> >
> > When searching for this issue I found the following patch:
> > http://www.haskell.org/pipermail/xmonad/2012-July/012810.html
> > I've been using it successfully since then, and in my opinion this new
> > behavior makes much more sense. My question is, does anyone know why the
> > patch hasn't been merged yet? Is there anything I can do to get it
> merged?
> >
> > Note that I don't have anything to do with the patch, all credits goes to
> > the original author Matthew Hague.
>
> Hi Hans,
>
> It helps to point out that you find the patch to be useful, since
> the change isn't unequivocally "better". For example, the
> workspace ordering I have (due XMonad.Actions.TopicSpace) puts
> the most recently used workspaces first. That's closer to what
> the current ordering getSortByIndex does than Matthew's patch. So
> I wouldn't be surprised if there are people who prefer the
> current behavior.
>
> So we can choose to do:
>
> 0. nothing
> 1. apply Matthew's patch as-is
>
> Making the result of getSortByIndex configurable by one of these
> methods:
>
> 2. store the function using XMonad.Util.ExtensibleState, which
> can set to the right one using a startupHook (or elsewhere).
> 3. passing the actual function as a parameter (or as part of
> another argument like XMonad.Hooks.DynamicLog.PP)
> 4. something else?
>
> Another note is that some other modules will be affected
> (benefit?) by the change to getSortByIndex:
>
> Actions/CycleWS.hs
> Actions/WorkspaceNames.hs
> Actions/SwapWorkspaces.hs
> Hooks/EwmhDesktops.hs
> Hooks/DynamicLog.hs
> Prompt/Workspace.hs
>
>
> Unless there are some objections, I will apply the patch (option
> 1) in a week.
>
> --
> Adam
>
[Attachment #5 (text/html)]
Hi Adam,<br><br>Thank you so much for your answer! Hopefully people will chime in if \
they're negatively affected by the patch.<br><br>Thanks,<br>Hans<br><br><div \
class="gmail_quote">On Sun, Jan 6, 2013 at 9:55 PM, adam vogt <span dir="ltr"><<a \
href="mailto:vogt.adam@gmail.com" target="_blank">vogt.adam@gmail.com</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div><div>On Sun, Jan 6, 2013 at 6:27 PM, Hans Chen <<a \
href="mailto:hanswchen@gmail.com" target="_blank">hanswchen@gmail.com</a>> \
wrote:<br> > I use DynamicWorkspaces with a few predefined workspaces. The problem \
is<br> > that when creating a new workspace, it gets sorted before my \
predefined<br> > workspaces and thus I can't always have e.g. "web" \
on Mod+1.<br> ><br>
> When searching for this issue I found the following patch:<br>
> <a href="http://www.haskell.org/pipermail/xmonad/2012-July/012810.html" \
target="_blank">http://www.haskell.org/pipermail/xmonad/2012-July/012810.html</a><br> \
> I've been using it successfully since then, and in my opinion this new<br> \
> behavior makes much more sense. My question is, does anyone know why the<br> \
> patch hasn't been merged yet? Is there anything I can do to get it \
merged?<br> ><br>
> Note that I don't have anything to do with the patch, all credits goes \
to<br> > the original author Matthew Hague.<br>
<br>
</div></div>Hi Hans,<br>
<br>
It helps to point out that you find the patch to be useful, since<br>
the change isn't unequivocally "better". For example, the<br>
workspace ordering I have (due XMonad.Actions.TopicSpace) puts<br>
the most recently used workspaces first. That's closer to what<br>
the current ordering getSortByIndex does than Matthew's patch. So<br>
I wouldn't be surprised if there are people who prefer the<br>
current behavior.<br>
<br>
So we can choose to do:<br>
<br>
0. nothing<br>
1. apply Matthew's patch as-is<br>
<br>
Making the result of getSortByIndex configurable by one of these<br>
methods:<br>
<br>
2. store the function using XMonad.Util.ExtensibleState, which<br>
can set to the right one using a startupHook (or elsewhere).<br>
3. passing the actual function as a parameter (or as part of<br>
another argument like XMonad.Hooks.DynamicLog.PP)<br>
4. something else?<br>
<br>
Another note is that some other modules will be affected<br>
(benefit?) by the change to getSortByIndex:<br>
<br>
Actions/CycleWS.hs<br>
Actions/WorkspaceNames.hs<br>
Actions/SwapWorkspaces.hs<br>
Hooks/EwmhDesktops.hs<br>
Hooks/DynamicLog.hs<br>
Prompt/Workspace.hs<br>
<br>
<br>
Unless there are some objections, I will apply the patch (option<br>
1) in a week.<br>
<br>
--<br>
Adam<br>
</blockquote></div><br>
_______________________________________________
xmonad mailing list
xmonad@haskell.org
http://www.haskell.org/mailman/listinfo/xmonad
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic