[prev in list] [next in list] [prev in thread] [next in thread]
List: xmlrpc-user
Subject: Re: DOMX509IssuerSerial WCF compatability
From: Rob Leland <the.rob.leland () gmail ! com>
Date: 2021-07-21 13:53:46
Message-ID: CAG9SN=uqHC9POwG18-9rwnyk3a0=-nP-3Fqt9b9a1=4vfauBFA () mail ! gmail ! com
[Download RAW message or body]
Thanks, I finished the code a week ago. I have compatability tests along
with 100% test coverage and the change should make minimal impact to
performance just waiting for employers permission to submit patch.
Thanks
On Mon, Jul 19, 2021, 03:05 Colm O hEigeartaigh <coheigea@apache.org> wrote:
> Hi Rob,
>
> Any contributions are welcome! I would prefer not to introduce a
> dependency on powermock, it shouldn't be too much extra work to verify
> the changes in a test.
>
> Colm.
>
> On Wed, Jul 14, 2021 at 11:07 PM Rob Leland <the.rob.leland@gmail.com>
> wrote:
> >
> > For instance,
> >
> > Would the developers be open to adding a dependency for the PowerMock
> reflection library so private methods could be tested, that way JUnits
> tests could be smaller and easier to understand.
> >
> > On Wed, Jul 14, 2021, 17:23 Rob Leland <the.rob.leland@gmail.com> wrote:
> >>
> >> I am in the early stages of making changes based on 2.3.3 to make this
> class optionally emit the DN name in a way that WCF likes.
> >>
> >> Specifically it will:
> >> 1) place spaces before each RDN.
> >> 2) Instead of escaping embedded commas and semicolons with a back
> slash to use quotes around the RDN text.
> >>
> >> so
> >> OU=(c) 2021 Entrust\, Inc.
> >>
> >> becomes
> >> OU="(c) 2021 Entrust, Inc."
> >>
> >> The first pass is using the underlying needed oracle code which is
> almost done , and the next pass would be a clean implementation.
> >>
> >> There are a few basic tests to cover my use case.
> >>
> >> The default behaviour would be unchanged.
> >>
> >> My question is this, beyond the contrib agreement, I was formally
> rleland@apache.org
> >> what other hurdles other than PR review would there be to eventually
> integrating this change to the baseline ?
> >>
> >> Thanks for your time and wss4j!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: dev-help@ws.apache.org
>
>
[Attachment #3 (text/html)]
<div dir="auto">Thanks, I finished the code a week ago. I have compatability tests \
along with 100% test coverage and the change should make minimal impact to \
performance just waiting for employers permission to submit patch.<div \
dir="auto"><br></div><div dir="auto">Thanks </div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 19, 2021, 03:05 \
Colm O hEigeartaigh <<a \
href="mailto:coheigea@apache.org">coheigea@apache.org</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rob,<br> <br>
Any contributions are welcome! I would prefer not to introduce a<br>
dependency on powermock, it shouldn't be too much extra work to verify<br>
the changes in a test.<br>
<br>
Colm.<br>
<br>
On Wed, Jul 14, 2021 at 11:07 PM Rob Leland <<a \
href="mailto:the.rob.leland@gmail.com" target="_blank" \
rel="noreferrer">the.rob.leland@gmail.com</a>> wrote:<br> ><br>
> For instance,<br>
><br>
> Would the developers be open to adding a dependency for the PowerMock reflection \
library so private methods could be tested, that way JUnits tests could be smaller \
and easier to understand.<br> ><br>
> On Wed, Jul 14, 2021, 17:23 Rob Leland <<a \
href="mailto:the.rob.leland@gmail.com" target="_blank" \
rel="noreferrer">the.rob.leland@gmail.com</a>> wrote:<br> >><br>
>> I am in the early stages of making changes based on 2.3.3 to make this class \
optionally emit the DN name in a way that WCF likes.<br> >><br>
>> Specifically it will:<br>
>> 1) place spaces before each RDN.<br>
>> 2) Instead of escaping embedded commas and semicolons with a back slash to \
use quotes around the RDN text.<br> >><br>
>> so<br>
>> OU=(c) 2021 Entrust\, Inc.<br>
>><br>
>> becomes<br>
>> OU="(c) 2021 Entrust, Inc."<br>
>><br>
>> The first pass is using the underlying needed oracle code which is almost \
done , and the next pass would be a clean implementation.<br> >><br>
>> There are a few basic tests to cover my use case.<br>
>><br>
>> The default behaviour would be unchanged.<br>
>><br>
>> My question is this, beyond the contrib agreement, I was formally <a \
href="mailto:rleland@apache.org" target="_blank" \
rel="noreferrer">rleland@apache.org</a><br> >> what other hurdles other than \
PR review would there be to eventually integrating this change to the baseline ?<br> \
>><br> >> Thanks for your time and wss4j!<br>
<br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href="mailto:dev-unsubscribe@ws.apache.org" \
target="_blank" rel="noreferrer">dev-unsubscribe@ws.apache.org</a><br> For additional \
commands, e-mail: <a href="mailto:dev-help@ws.apache.org" target="_blank" \
rel="noreferrer">dev-help@ws.apache.org</a><br> <br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic