[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xmlrpc-user
Subject:    [GitHub] [ws-wss4j] deshankoswatte opened a new pull request #6: Improve thread safety of subclass T
From:       GitBox <git () apache ! org>
Date:       2020-02-19 4:38:56
Message-ID: infra.6.MDExOlB1bGxSZXF1ZXN0Mzc2OTU5NzU0.gitbox () gitbox ! apache ! org
[Download RAW message or body]

deshankoswatte opened a new pull request #6: Improve thread safety of subclass \
                ThreadLocalSecurityProvider.
URL: https://github.com/apache/ws-wss4j/pull/6
 
 
   - If a synchronized method is overridden in a subclass, the compiler does not \
require the overriding method to be synchronized. However, if the overriding method \
is not synchronized, the thread-safety of the subclass may be broken. As for [1].   
   - This PR improves the thread safety of ThreadLocalSecurityProvider by adding the \
synchronized keywords to the overridden synchronized methods. Fixes some of the \
alerts in [https://lgtm.com/projects/g/apache/ws-wss4j/alerts/?mode=list](https://lgtm.com/projects/g/apache/ws-wss4j/alerts/?mode=list).
  
   [1] - [https://help.semmle.com/wiki/display/JAVA/Non-synchronized+override+of+synch \
ronized+method](https://help.semmle.com/wiki/display/JAVA/Non-synchronized+override+of+synchronized+method) \
  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]