[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xmlrpc-user
Subject:    [jira] [Commented] (WSS-605) Ensure the ws-security-dom can work with the saaj impl in latest Java9 
From:       "Colm O hEigeartaigh (JIRA)" <jira () apache ! org>
Date:       2017-03-31 14:59:41
Message-ID: JIRA.13060593.1490945406000.176550.1490972381535 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/WSS-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951069#comment-15951069 \
] 

Colm O hEigeartaigh commented on WSS-605:
-----------------------------------------

I think I'd prefer if the method was renamed to "cloneElement" and put the \
"(Element)keyInfo.getElement().cloneNode(true)" statement in there as well. I also \
think that the change to WSSecHeader is unnecessary, you can just call \
element.getOwnerDocument() in WSSecSignatureBase. In \
WSSecurityUtil.prependChildElement, I'd prefer not to change the "child" argument but \
assign it to a local variable. Also log the exception, not printStackTrace. Instead \
of adding a new method createElementInSameNamespace, we could just change the parent \
argument of the existing method from Element to Node.

> Ensure the ws-security-dom can work with the saaj impl in latest Java9 EA kit
> -----------------------------------------------------------------------------
> 
> Key: WSS-605
> URL: https://issues.apache.org/jira/browse/WSS-605
> Project: WSS4J
> Issue Type: Improvement
> Reporter: Freeman Fang
> Assignee: Colm O hEigeartaigh
> Attachments: WSS-605-new.patch, WSS-605.patch
> 
> 
> In latest JDK9 EA kit, the SAAJ api changed, for example, the
> com.sun.xml.internal.messaging.saaj.soap.impl.ElementImpl now not extends its dom \
> counterpart com.sun.org.apache.xerces.internal.dom.ElementNSImpl, instead it store \
> it as a field and add a method {code}
> public Element getDomElement() {
> return element;
> }
> {code}
> to get it. so the extends become aggregates.
> This change cause lots of ClassCastException and wrong DocOwner exception which use \
> ws-seucrity-dom which rely on the Dom and Saaj api heavily.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]