[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xml-cocoon-dev
Subject:    XMLSerializer.java why not  implements CacheableProcessingComponent
From:       Thorsten Scherler <thorsten () apache ! org>
Date:       2010-12-30 12:08:12
Message-ID: 1293710892.3641.28.camel () mcKenny
[Download RAW message or body]


Hi all,

I wonder is there a reason why nobody did

-public class XMLSerializer extends EncodingSerializer {
+public class XMLSerializer extends EncodingSerializer implements
CacheableProcessingComponent {

I am doing some caching enhancement for a client and using the profiler
I found out that my 100% cacheable page did not return 304. So I
stumbled upon the above. 

When I make the XMLSerializer implementing CacheableProcessingComponent
the whole pipeline is returning 304 which I am looking for that the
status is for the response. 

Without the above patch I always get a 200 since the serializer is not
cacheable hence the whole pipe.

Is there an obvious reason that I am not seeing why the serializer
should not be cacheable?

TIA for any light!

salu2
-- 
Thorsten Scherler <thorsten.at.apache.org>
codeBusters S.L. - web based systems
<consulting, training and solutions>
http://www.codebusters.es/

["smime.p7s" (application/x-pkcs7-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]