[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xml-cocoon-dev
Subject:    Re: CForms widget ID naming (was Re: [Vote] Releasing on friday)
From:       Sylvain Wallez <sylvain () apache ! org>
Date:       2005-11-03 12:39:06
Message-ID: 436A04EA.5070701 () apache ! org
[Download RAW message or body]

Sylvain Wallez wrote:
> Carsten Ziegeler wrote:
>> Sylvain Wallez wrote:
>>  
>>> This usage in CForms has already been introduced by the recent 
>>> library stuff, which associates prefixes to libraries, thus 
>>> effectively forbidding the use of ":" in widget ids (otherwise you 
>>> cannot differenciate between a widget name and a composite name that 
>>> references a library widget).
>>>
>>> That is why I chose this character. The "/" and "." are also 
>>> forbidden (used for lookup paths). The "." cannot be used as it is 
>>> used to combine widget names in the generated IDs, and thus would 
>>> lead to a similar problem as the current one: "-" can conflict with 
>>> siblings, and "." can conflict with children.
>>>
>>>     
>> Do we already validate a widget id if it does not contain all of these
>> forbidden characters? If not, we really should check this and throw an
>> exception when the model is read. Early failing is better than
>> unpredictable results later on.
>>   
>
> Yep. The "." and "/" are already checked in 
> AbstractWidgetDefinition.setCommonProperties(). We just need to add ":".
>
> BTW, I'm ready to commit the updated stylesheets, which I tested on IE 
> 6, Firefox and Safari.

Ok, changes committed.

Let's get this baby 2.1.8 out!

Sylvain

-- 
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director

[prev in list] [next in list] [prev in thread] [next in thread]