[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    Re: [xine-devel] [PATCH] Fix PulseAudio support without pkg-config
From:       Darren Salt <linux () youmustbejoking ! demon ! co ! uk>
Date:       2008-10-15 22:42:25
Message-ID: 4FF44C1A14%linux () youmustbejoking ! demon ! co ! uk
[Download RAW message or body]

I demand that Matthias Ringwald may or may not have written...

> # HG changeset patch
> # User mringwal@Macintosh.local
> # Date 1224108912 -7200
> # Node ID c00be186074eb83b7a2a9174941c311b79ca4933
> # Parent  f98dfc2d6b7aa21f134a40ca2d5fa95347b6eac5
> Fix PulseAudio support without pkg-config
> 
> If --with-pulseaudio given, trust user.
> Replaced configure test for PulseAudio version >= 0.9.7 by cpp test for
> PA_PROTOCOL_VERSION >= 11 (0.9.6 has version 10, 0.9.7 has version 11).
> Tell autoconf to actually expand PULSEAUDIO_{CFLAGS|LIBS}
> 
> diff -r f98dfc2d6b7a -r c00be186074e configure.ac
> --- a/configure.ac	Thu Oct 02 17:31:31 2008 +0200
> +++ b/configure.ac	Thu Oct 16 00:15:12 2008 +0200
[snip]
> +   if test "x$with_pulseaudio" == "xyes"; then
> +      have_pulseaudio=yes
> +   else
> +      PKG_CHECK_MODULES([PULSEAUDIO], [libpulse],  
> [have_pulseaudio="yes"], [have_pulseaudio="no"])
>      fi
>   fi
>   AM_CONDITIONAL(HAVE_PULSEAUDIO, [test "x$have_pulseaudio" = x"yes"])

NAK. This doesn't cover --without-pulseaudio.

> +
> +AC_SUBST([PULSEAUDIO_CFLAGS])
> +AC_SUBST([PULSEAUDIO_LIBS])

Looks like we might want this separately.

[snip]
> diff -r f98dfc2d6b7a -r c00be186074e src/audio_out/audio_pulse_out.c
> --- a/src/audio_out/audio_pulse_out.c	Thu Oct 02 17:31:31 2008 +0200
> +++ b/src/audio_out/audio_pulse_out.c	Thu Oct 16 00:15:12 2008 +0200
> @@ -218,7 +218,8 @@
[snip]
> -#ifdef HAVE_PULSEAUDIO_0_9_7
> +#if PA_PROTOCOL_VERSION >= 11
> +  /* PulseAudio 0.9.7 and newer */

Seems reasonable; again, separately.

[snip]
-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Use more efficient products. Use less.          BE MORE ENERGY EFFICIENT.

I'd like to, but I'm teaching my ferret to yodel.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel
[prev in list] [next in list] [prev in thread] [next in thread]