[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    [xine-devel] CDDB query response error code mistaken
From:       Боян Табак� <blade.alslayer () gmail ! com>
Date:       2006-08-27 11:52:24
Message-ID: 200608271452.33514.blade.alslayer () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


When server finds inexact matches to the query, it returns error code 211, 
rather than 210 as assumed in the xine-lib 1.1.2 source 
(src/input/inpu_cdaa.c lines 1670 and 1691). The code that handles the list 
is there, but not triggered due to the mistaken error code. This causes no 
CDDB information to be read.
Here is a patch:

--- input_cdda.c.old    2006-08-27 14:41:50.000000000 +0300
+++ src/input/input_cdda.c      2006-08-27 14:41:29.000000000 +0300
@@ -1667,7 +1667,7 @@

     memset(&buffer, 0, sizeof(buffer));
     err = _cdda_cddb_socket_read(this, buffer, sizeof(buffer) - 1);
-    if (err < 0 || (((err = _cdda_cddb_handle_code(buffer)) != 200) && 
(err != 210))) {
+    if (err < 0 || (((err = _cdda_cddb_handle_code(buffer)) != 200) && 
(err != 211))) {
       xprintf(this->stream->xine, XINE_VERBOSITY_DEBUG,
              "input_cdda: cddb query command returned error code '%03d'.\n", 
err);
       _cdda_cddb_socket_close(this);
@@ -1688,7 +1688,7 @@
       }
     }

-    if (err == 210) {
+    if (err == 211) {
       memset(&buffer, 0, sizeof(buffer));
       err = _cdda_cddb_socket_read(this, buffer, sizeof(buffer) - 1);
       if (err < 0) {

NB: I have not subscribed to the mailing list, so please reply to my personal 
e-mail too.

-- 
Blade hails you...

[Attachment #5 (application/pgp-signature)]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel


[prev in list] [next in list] [prev in thread] [next in thread]