[prev in list] [next in list] [prev in thread] [next in thread] 

List:       xine-devel
Subject:    [xine-devel] Re: Odd comparison in libcdio (compiler warning)
From:       "R. Bernstein" <rocky () panix ! com>
Date:       2005-05-07 22:23:43
Message-ID: 17021.16367.177696.15336 () panix3 ! panix ! com
[Download RAW message or body]

The intent is to figure out the blocksize that has been encoded in the
image.  I'm not aware of a document that describes the Nero image
format so this is likely a guess.

Comparing with current libcdio sources at around line 663, 
  http://savannah.gnu.org/cgi-bin/viewcvs/libcdio/libcdio/lib/driver/image/nrg.c?rev=1.15&content-type=text/vnd.viewcvs-markup


yes that should probably be as you suggest and the change has been
made in CVS.

The current libcdio sources are more likely to be more correct as they
are better maintained. 

As I compare the the two versions, I see there are a number of little
differences, so if any of this is of concern (VCD playing, libcdio
CDDA playing, Nero image CD reading, etc.) you're probably better off
installing libcdio and vcdimager externally.

Darren Salt queries:
 > src/input/vcd/libcdio/image/nrg.c line 663 contains the following test:
 >   0 == _start * CDIO_CD_FRAMESIZE_RAW == _start2
 > 
 > What exactly is the intent here? I *think* that it's meant to be this:
 >   _start * CDIO_CD_FRAMESIZE_RAW != _start2
 > 


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel


[prev in list] [next in list] [prev in thread] [next in thread]